Skip to content

Update hooks and use autopep8 + add-trailing-comma instead of black #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025

Conversation

mxr
Copy link
Contributor

@mxr mxr commented Jul 7, 2025

reorder-python-imports and black are incompatible (psf/black#4175). This blocks automatic pre-commit updates (#1912). As a workaround, replace black with autopep8 and add-trailing-comma

@mxr mxr marked this pull request as ready for review July 8, 2025 16:36
@asottile
Copy link
Member

I'm in favor, we'll see what @sigmavirus24 thinks -- this at least would allow us to get updates. we lose some of the automatic formatting that black decides though

maybe add-trailing-comma could get us the rest of the important parts though?

@mxr mxr changed the title Update hooks and use autopep8 instead of black Update hooks and use autopep8 + add-trailing-comma instead of black Jul 13, 2025
@sigmavirus24
Copy link
Member

I'm 👍 on anything that gets auto-updates working again

@mxr mxr changed the title Update hooks and use autopep8 + add-trailing-comma instead of black Update hooks and use autopep8 + add-trailing-comma instead of black Jul 20, 2025
@mxr
Copy link
Contributor Author

mxr commented Jul 21, 2025

@asottile @sigmavirus24 sounds like we are all on the same page. This PR is tidied up from my side now. Thank you!

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(kitty cat script broken on this computer sadface)

@asottile asottile merged commit 8fdc755 into PyCQA:main Jul 24, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants