Skip to content

Conversation

Tpt
Copy link
Contributor

@Tpt Tpt commented Sep 3, 2025

Returns the collections.abc type

@Tpt Tpt force-pushed the tpt/abc-type-info branch from c50498a to 157f210 Compare September 3, 2025 13:15
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, given the wider context in #5387 this makes sense 👍

assert_eq!(
downcaster.borrow_mut(py).failed.take().unwrap().to_string(),
"TypeError: 'MySequence' object cannot be converted to 'Iterator'"
"TypeError: 'MySequence' object cannot be converted to 'PyIterator'"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While a "regression", we expect this to be improved imminently in #5352 I guess.

@davidhewitt davidhewitt added this pull request to the merge queue Sep 3, 2025
Merged via the queue into PyO3:main with commit c5c941e Sep 3, 2025
42 of 44 checks passed
@Tpt Tpt deleted the tpt/abc-type-info branch September 4, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants