Skip to content

Conversation

nikkon-dev
Copy link

fixes #5431

Thank you for contributing to PyO3!

By submitting these contributions you agree for them to be dual-licensed under PyO3's MIT OR Apache-2.0 license.

Please consider adding the following to your pull request:

  • an entry for this PR in newsfragments - see [https://pyo3.rs/main/contributing.html#documenting-changes]
    • or start the PR title with docs: if this is a docs-only change to skip the check
    • or start the PR title with ci: if this is a ci-only change to skip the check
  • docs to all new functions and / or detail in the guide
  • tests for all new or changed functions

PyO3's CI pipeline will check your pull request, thus make sure you have checked the Contributing.md guidelines. To run most of its tests locally, you can run nox. See nox --list-sessions for a list of supported actions.

@davidhewitt
Copy link
Member

Thanks for the report & the proposed fix. I think we can just delete the file - #5456

@davidhewitt
Copy link
Member

Closed as #5456 got merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyO3 cannot be vendored in Git repositories
2 participants