optimize Py<T>::drop
for the case when attached
#5454
Merged
+58
−35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking again at #5350 and realised it could be worth optimizing the
Drop
implementation ofPy<T>
to bias towards the case when the thread is attached, as I think this is a common scenario.As part of the optimizations I split the code into a fast and
#[cold]
path, and also removed#[track_caller]
as the panic only happens if the reference pool is not enabled.