docs: replace extension-module feature in docs
#5588
+63
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
reviewed
Nov 1, 2025
Comment on lines
74
to
76
| PyO3 has some Cargo features to configure projects for building Python extension modules: | ||
|
|
||
| - The `extension-module` feature, which must be enabled when building Python extension modules. | ||
| - The `PYO3_BUILD_EXTENSION_MODULE` environment variable, which must be set when building Python extension modules. |
Contributor
There was a problem hiding this comment.
The bullet doesn't match the intro :-)
It's probably worth saying that people don't generally need to set this themselves, because maturin/setuptools-rust set it.
Member
Author
messense
pushed a commit
to PyO3/maturin
that referenced
this pull request
Nov 4, 2025
…2821) Similar change as PyO3/pyo3#5588
Icxolu
approved these changes
Nov 5, 2025
Co-authored-by: Icxolu <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
Author
|
Looks like this failed to merge because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up from #5343
This updates documentation across the codebase to discourage use of the
extension-modulefeature and to instead rely on thePYO3_BUILD_EXTENSION_MODULEenvironment variable when relevant.