refactor(invite): improve typing, simplify typeddicts - #3313
Open
vmphase wants to merge 27 commits into
Open
Conversation
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3313/head:pr-3313
git checkout pr-3313This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3313/head |
Signed-off-by: Michael <vmphase.dev@gmail.com>
Paillat-dev
reviewed
Jul 26, 2026
Paillat-dev
left a comment
Member
There was a problem hiding this comment.
What are the specific cases where code is missing ?
Member
Author
Can't recall for now but it potentially could be, because it returns a partial invite object. |
Paillat-dev
reviewed
Aug 3, 2026
vmphase
force-pushed
the
fix/invite-optional-code
branch
from
August 3, 2026 19:03
670b844 to
2d2c542
Compare
ToothyDev
previously approved these changes
Aug 7, 2026
Lulalaby
previously approved these changes
Aug 7, 2026
NeloBlivion
previously approved these changes
Aug 7, 2026
Paillat-dev
previously approved these changes
Aug 10, 2026
Paillat-dev
left a comment
Member
There was a problem hiding this comment.
Very nitpicky comments but lgtm, thanks, and improving typing is always nice.
vmphase
dismissed stale reviews from Paillat-dev, NeloBlivion, Lulalaby, and ToothyDev
via
August 10, 2026 16:42
9b43c49
vmphase
requested review from
Lulalaby,
NeloBlivion,
Paillat-dev and
ToothyDev
August 10, 2026 16:42
ToothyDev
requested changes
Aug 10, 2026
Co-authored-by: ToothyDev <55001472+ToothyDev@users.noreply.github.com> Signed-off-by: Michael <vmphase.dev@gmail.com>
Co-authored-by: ToothyDev <55001472+ToothyDev@users.noreply.github.com> Signed-off-by: Michael <vmphase.dev@gmail.com>
ToothyDev
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Invite.__init__acceptsVanityInviteas a type, butVanityInvite.codeis optional.Hence, if
codeisNone,Invite.urlinterpolates it (str(None)yieldsNone) resultinghttps://discord.gg/None.Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.