Skip to content

Modify two PyROS solver tests #3694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 12, 2025

Conversation

shermanjasonaf
Copy link
Contributor

Fixes #2696.

Changes proposed in this PR:

This PR modifies the two PyROS tests discussed in #2696, as follows:

  • The models and uncertainty sets are simplified, so that the likelihood of failures arising from subsolver errors in the future is reduced
  • IPOPT is used in lieu of BARON/SCIP as the PyROS subsolver (note: in both tests, all PyROS subproblems are now expected to be convex)
  • More rigorous checks are performed in both tests

Further, the test pyomo/contrib/pyros/tests/test_grcs.py::testMasterFeasibilityUnitConsistency::test_two_stg_mod_with_axis_aligned_set is renamed to pyomo/contrib/pyros/tests/test_grcs.py::TestAvoidUnitConsistencyChecks::test_avoid_unit_consistency_checks

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@github-project-automation github-project-automation bot moved this from Todo to Reviewer Approved in Pyomo 6.9.4 Release Aug 12, 2025
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.48%. Comparing base (b2463cc) to head (7d73381).
⚠️ Report is 332 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3694      +/-   ##
==========================================
+ Coverage   89.08%   89.48%   +0.40%     
==========================================
  Files         889      894       +5     
  Lines      102746   107520    +4774     
==========================================
+ Hits        91527    96211    +4684     
- Misses      11219    11309      +90     
Flag Coverage Δ
builders 26.67% <ø> (+0.01%) ⬆️
default 85.66% <ø> (?)
expensive 34.02% <ø> (?)
linux 86.95% <ø> (-1.89%) ⬇️
linux_other 86.95% <ø> (+0.11%) ⬆️
osx 83.25% <ø> (+0.12%) ⬆️
win 85.15% <ø> (?)
win_other 85.15% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mrmundt mrmundt merged commit 756c2c1 into Pyomo:main Aug 12, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer Approved to Done in Pyomo 6.9.4 Release Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Revisit skipped Baron tests
4 participants