Skip to content

Finish PR 734 : typo in \text{max_nz} in ot.utils.projection_sparse_simplex #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

rflamary
Copy link
Collaborator

@rflamary rflamary commented Jul 25, 2025

Types of changes

This is a version of PR #734 with release file completed and doc updated

Motivation and context / Related issue

How has this been tested (if it applies)

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

Copy link

codecov bot commented Jul 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.10%. Comparing base (a97a788) to head (7b343b2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #746   +/-   ##
=======================================
  Coverage   97.10%   97.10%           
=======================================
  Files         100      100           
  Lines       20453    20453           
=======================================
  Hits        19861    19861           
  Misses        592      592           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -156,8 +160,9 @@ def projection_sparse_simplex(V, max_nz, z=1, axis=None, nx=None):
-------
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while you're at it you fix them int he 3 lines above.
Screenshot 2025-07-25 at 17 41 13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants