Two Fixes to constant prop, IList and try_eval_const_pure
#524
+90
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he method is not pure
… missing runtime implementation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
weinbe58
added
the
priority: high
Roger-luo
reviewed
Oct 10, 2025
Comment on lines
+102
to
+106
| try: | ||
| value = method(self._interp, _frame, stmt) | ||
| except NotImplementedError: | ||
| # the concrete interpreter doesn't have the implementation so we cannot evaluate it | ||
| return tuple(Unknown() for _ in stmt.results) |
There was a problem hiding this comment.
this is redundant? if the method is not None that indicates there is an implementation for the concrete interpretation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes in this PR:
ilistdialect that gaurd against non-pure execution ofmapfor_eachfoldl, etc.try_eval_const_purein cases where the concrete interpreter is missing an implementation of a statement that is pure, falling back to returningUnknownfor all results.