Skip to content

Improved some performance - #2495

Merged
creatorfromhell merged 3 commits into
QuickShop-Community:hikarifrom
YuanYuanOwO:improved-some-performance
Aug 19, 2026
Merged

Improved some performance#2495
creatorfromhell merged 3 commits into
QuickShop-Community:hikarifrom
YuanYuanOwO:improved-some-performance

Conversation

@YuanYuanOwO

Copy link
Copy Markdown
Collaborator

Summary

  1. Cleanup Imports
  2. The cleanup timer now also checks entry.getValue().isEmpty(), and empty internal Maps will be garbage collected.
  3. Fix the duplicate .clone logic; there is already one instance of .clone in Shop.getitem.

Type of Change

  • Feature
  • Bug fix
  • Refactor / Cleanup
  • Documentation
  • Breaking change

Basic Checks

  • I have tested these changes locally
  • I confirm no undocumented AI-generated code was used in this submission

Notes (optional)

Add anything important for reviewers:

  • Why this change was needed
  • Edge cases
  • Implementation details

Config Changes (if applicable)

Only fill this out if you touched config:

  • Added/changed:
  • Default values:
  • Any risks or notes:

Breaking Changes (if applicable)

  • What changed:
  • Required action:

Related (optional)

  • Fixes Issue #
  • Related to Issue/PR #

@creatorfromhell
creatorfromhell merged commit 3848b18 into QuickShop-Community:hikari Aug 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants