-
Notifications
You must be signed in to change notification settings - Fork 13
Update to 1.21.9 #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 1.21.9 #65
Conversation
…ainers, don't store all flags in a locked container's flag set and fallback to config flags
PR should be ready to review now, there have been a few major refactors, as well as improvements to the mod's config file, a new Will update PR description in a bit. Re-running the actions will probably fix them. |
I've cleaned up/improved the CI workflows as well to make them more reliable, and fixed the CI badge in the README too :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
This PR updates the mod to 1.21.9. It also performs major refactors to texts used in the mod, lock flags, and the mod's configuration file.
Full list of changes:
Build/project
LockType
LockType
class, replacing it with aType
enum in theLock
interface, which does the same things, but simpler.Mod configuration
HTMConfig
class has been refactored into a immutable record, using a codec for reading and writing.snake_case
:canTrustedPlayersBreakChests
->can_trusted_players_break_chests
defaultFlags
->default_flags
autolockingContainers
->auto_locking_containers
SingleBlockSelector
record has been created for reading auto-locking containers. This selector can either be a single block identifier, or a block tag.BlockFlagSet
.SingleBlockSelector
, meaning you can use a block identifier or a block tag.1.1.4
(released almost 4 years ago) is no longer supported.Flags
HTMContainerLock
record, instead a dedicatedFlagSet
class has been created, which uses anEnumMap
internally.FlagSet
class itself has been designed to be immutable, and has no methods for modifying the map directly.COPPER_GOLEMS
flag) and newly placed locked containers.COPPER_GOLEMS
flag has been added, used to control whether copper golems can open a locked container or not.Commands
/htm flag
now displays values for any flag, even when not set on a locked container./htm flag <type>
has been added to reset a flag on a locked container to its default value (specified in the configuration).Texts
Text.translatable
have been replaced with constants inHTMTexts
.nl_nl
).Other things
An example new configuration file is as follows:
The file above disables copper golem access to all locked containers except copper chests and normal chests.