Add ability to enable or disable #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add icon (with source) - Update `strict_min_version` to 79 and add other code for toolbar icon to be clickable - Update code for enable disable feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redirecting automatically to .onion domain always, without option, is useful. But without being able to disable it for some specific use-cases (for example if something is not working on .onion domain but is working on clearnet site) makes it less convenient.
Disabling it from manage extensions page every time is possible but inconvenient. This feature makes it easier. Clicking the toolbar icon toggles between enabled and disabled.
strict_min_versionto 79 and add other code for toolbar icon to be clickableOriginal icon svg is from https://publicdomainvectors.org/en/free-clipart/Onion-vector-symbol/69402.html which says it is under public domain.
Limitations (or feature?):
This setting is not saved (yet), so it will reset to enabled after browser restart for example. The setting is universal and not tab-specific.