Skip to content

v2: refactor JSX handler attributes #8060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: refactor(router): improve plugin retrieval logic in Vite adapter
merged 16 commits into from
Oct 27, 2025
Merged

v2: refactor JSX handler attributes #8060

merged 16 commits into from
Oct 27, 2025

Conversation

@wmertens
Copy link
Member

@wmertens wmertens commented Oct 14, 2025 •
edited
Loading

See QwikDev/qwik-evolution#316

BREAKING: onCustom-Event now listens for custom-event, not customEvent. Instead, there's on-CustomEvent, you add - after on and it becomes case sensitive.

improvements: less translations between jsx and vnodes, sane event capitalization

fixes:

  • event merging with case differences
  • window and document event triggering on CSR
  • inline component templates with useOn

@wmertens wmertens requested review from a team as code owners October 14, 2025 16:43
@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 61208e1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wmertens wmertens changed the title V2-fix-repl v2: fix repl correctly Oct 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 61208e1

@wmertens wmertens marked this pull request as draft October 15, 2025 08:30
@wmertens wmertens force-pushed the v2-fix-repl branch 3 times, most recently from 5da521c to ebfe2f4 Compare October 15, 2025 18:32
@Varixo Varixo force-pushed the v2-fix-repl branch 2 times, most recently from 998d08b to 3a7577f Compare October 16, 2025 13:46
@wmertens wmertens changed the title v2: fix repl correctly v2: refactor JSX handler attributes Oct 19, 2025
@wmertens wmertens mentioned this pull request Oct 19, 2025
Closed
@wmertens wmertens force-pushed the v2-fix-repl branch 3 times, most recently from 00287c6 to 6fb3dfb Compare October 26, 2025 11:54
@wmertens wmertens force-pushed the v2-fix-repl branch 2 times, most recently from 2eb9a98 to 164151b Compare October 27, 2025 10:07
@wmertens wmertens marked this pull request as ready for review October 27, 2025 10:32
@wmertens wmertens requested a review from a team as a code owner October 27, 2025 10:32
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 27, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8060

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8060

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8060

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8060

commit: 61208e1

@wmertens wmertens merged commit 61bec49 into build/v2 Oct 27, 2025
20 checks passed
@wmertens wmertens deleted the v2-fix-repl branch October 27, 2025 16:15
@github-actions github-actions bot mentioned this pull request Oct 27, 2025
Merged
@wmertens wmertens self-assigned this Oct 27, 2025
@wmertens wmertens moved this from Backlog to Done in Qwik Development Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@wmertens wmertens

Labels

None yet

Projects

Qwik Development
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wmertens @Varixo