-
Notifications
You must be signed in to change notification settings - Fork 71
support for publishToMavenLocal
#83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@AbhiTheModder Sorry I don't know how I didn't see this PR for long. |
While using a submodule isn't strictly necessary (users could clone ARSCLib separately and publish it to their local Maven manually, which would also work after this idea gets accepted), adopting it as a submodule can streamline the process. There might be instances where we forget to clone ARSCLib and run instead of implementation("com.reandroid:ARSCLib:+") eliminating the need to update a remote Maven repo (though optionally, this can still be done if you wish for people who like MavenCentral) or manually updating libraries. Here's a small video: arsclib.mp4 |
@AbhiTheModder Thank you! I learned something. As personal hack I place naughty dependencies under We can't use I think it is complicated for regular users of APKEditor to clone ARSCLib separately. |
Agreed, that's why I suggested including it as a submodule and updating the build instructions in the README. Anyway, that's for APKEditor. What I'm proposing here is for ARSCLib is purely for my own (& others if they would prefer MavenLocal) convenience (so you can ignore it if it's not up to your liking<3 ) . This way, I could use the latest updates without relying on jars in my project. Currently, I have to keep this branch of mine updated with upstream just to use it :) |
Ouch, that's nice & good for anyone to try for latest changes, but this line there fears me:
|
Just a proposal, this makes it easier to use in a project without building & including/updating jar file everytime, (for eg. adding as submodule and simply running
./gradlew publishToMavenLocal
)