Skip to content

[AOMP] Add shellcheck workflow #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: aomp-dev
Choose a base branch
from
Open

[AOMP] Add shellcheck workflow #1435

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a21998a
[AOMP] Adds shellcheck workflow
jplehr May 12, 2025
84a52b9
[AOMP] Set warning severity as to consider
jplehr May 12, 2025
dd17749
[AOMP] Change to info
jplehr May 12, 2025
05b7731
[AOMP] Make the job fail with error
jplehr May 12, 2025
5329554
[AOMP] Remove apt update/shellcheck install
jplehr May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/aomp-shell.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
name: AOMP Lint

on:
push:
pull_request:

jobs:
aomp-lint:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2

- name: Run shellcheck
run: |
find . -name "*.sh" | xargs shellcheck -S info {} \;
Copy link

@e-kwsm e-kwsm Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax is wrong, which must be

Suggested change
find . -name "*.sh" | xargs shellcheck -S info {} \;
find . -name "*.sh" -exec shellcheck -S info {} +

or

Suggested change
find . -name "*.sh" | xargs shellcheck -S info {} \;
find . -name "*.sh" | xargs shellcheck -S info

Loading