Rework constructHipPath so HIP_PATH env var is lower priority. #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
added a commit
to ROCm/TheRock
that referenced
this pull request
Aug 5, 2025
Fixes #1200. Sent upstream for review as well at ROCm/llvm-project#289. The HIP SDK sets the `HIP_PATH` environment variable, which hipcc and hipconfig were using instead of neighboring files. This resulted in errors like this when the HIP SDK was installed: ``` λ .\build\compiler\hipcc\dist\bin\hipcc --version 'C:\Program' is not recognized as an internal or external command, operable program or batch file. The system cannot find the path specified. 'nvcc' is not recognized as an internal or external command, operable program or batch file. Device not supported - Defaulting to AMD HIP version: 6.2.41512-db3292736 The system cannot find the path specified. failed to execute:""C:\Program Files\AMD\ROCm\6.2\lib\llvm\bin\clang.exe" --driver-mode=g++ -O3 -fuse-ld=lld --ld-path="C:\Program Files\AMD\ROCm\6.2\lib\llvm\bin\lld-link.exe" -Llib --hip-link --version" ``` A robust way to handle this would be to stamp all information about related tools into the tools themselves during packaging, rather than use global state like environment variables or heuristics like scanning the file system. I think once we've progressed further towards rolling out the new ROCm "superrepos" and open source CI/CD we can make those deeper changes. For now, I've extended the brittle logic with another special case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on ROCm/TheRock#1200. Tested downstream (via a patch) in ROCm/TheRock#1201.
The HIP SDK sets the
HIP_PATHenvironment variable, which hipcc and hipconfig were using instead of neighboring files.A robust way to handle this would be to stamp all information about related tools into the tools themselves during packaging, rather than use global state like environment variables or heuristics like scanning the file system. I think once we've progressed further towards rolling out the new ROCm "superrepos" and open source CI/CD we can make those deeper changes. For now, I've extended the brittle logic with another special case.