refactor(likes): make like/unlike operations atomic and enhance like action tests #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap the like and unlike logic in `django.db.transaction.atomic()` to ensure that the creation/deletion of the like and the update of the promo's `like_count` are performed as a single, indivisible operation. This prevents potential race conditions and data inconsistency. Add `promo.refresh_from_db()` after the `F()` expression update to ensure the promo object reflects the latest database state.
Refactor the `TestUserPromoLikeActions` test case to be more concise and readable. - Introduce helper methods (`_create_user_and_get_token`, `_create_promo`, `_auth`, `_get_user_promo`, `_get_business_promo`, `_like`, `_unlike`) to reduce code duplication and improve clarity. - Consolidate multiple, granular tests into fewer, more comprehensive tests (`test_initial_promo_state`, `test_like_action`, `test_like_idempotency`, etc.). - Remove the dependency on a strict, numbered execution order, making the test suite more robust and easier to maintain. - Add a `tearDown` method to clean up credentials after each test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap the like and unlike logic in
django.db.transaction.atomic()to ensure that the creation/deletion ofLikerecords and the corresponding update of the promo’slike_countoccur as a single, indivisible operation. This prevents race conditions and data inconsistencies. After updatinglike_countusingF(), callpromo.refresh_from_db()to reflect the latest database state in the model instance.Refactor the
TestUserPromoLikeActionstest suite for clarity and maintainability:_create_user_and_get_token,_create_promo,_auth,_get_user_promo,_get_business_promo,_like,_unlike) to eliminate duplication.test_initial_promo_state,test_like_action,test_like_idempotency, etc.).tearDown(), ensuring test isolation and robustness.