refactor(feed): Simplify promo feed logic and related views #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the promo feed generation and comment handling to improve code structure, efficiency, and maintainability. Key changes: - Moved the complex feed generation logic from `UserFeedView` into a new `PromoManager.get_feed_for_user` method. This centralizes business logic in the manager layer, simplifying the view and making the query logic reusable. - The new manager method encapsulates filtering for active promos and targeting by user age and country. - Optimized category filtering to use a direct `__icontains` database query, which is more efficient than the previous Python-based filtering. - Introduced a `PromoObjectMixin` to reduce code duplication in comment-related views (`PromoCommentListCreateView`, `PromoCommentDetailView`) by abstracting the common task of retrieving the associated promo object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the promo feed generation and comment handling to improve code structure, efficiency, and maintainability.
Key changes:
UserFeedViewinto a newPromoManager.get_feed_for_usermethod. This centralizes business logic in the manager layer, simplifying the view and making the query logic reusable.__icontainsdatabase query, which is more efficient than the previous Python-based filtering.PromoObjectMixinto reduce code duplication in comment-related views (PromoCommentListCreateView,PromoCommentDetailView) by abstracting the common task of retrieving the associated promo object.