fix(ci): Correct Codecov reporting and file discovery #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the CI workflow to explicitly set the `directory` for the Codecov action. This ensures the action correctly locates the `coverage.xml` file within the `promo_code` directory, resolving potential pathing issues during the upload process.
This commit refactors the test and coverage generation step in the CI workflow. - The `cd` command is removed, and paths are handled directly in the `coverage` command for better clarity. - The `--source` option is added to ensure coverage is measured for the intended `business`, `core`, and `user` apps.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves a critical issue where Codecov was reporting inaccurate coverage metrics due to missing source files. The CI workflow has been updated to ensure all relevant files are discovered and processed correctly.
Key changes:
coverage runcommand now explicitly specifies the source directory (--source='.') and the target applications (business,core,user). This forcescoverageto analyze all relevant files, not just those touched by tests, fixing the incorrect file and line counts in Codecov reports..coveragercconfiguration file is now correctly specified, ensuring custom settings are applied.directoryto locate thecoverage.xmlreport.