Build all binaries with a Makefile - #213
Conversation
|
Hi, thanks for you interest, but I'm not used to makefiles and such, and i don't need to mess with it for now. (I have scripts to update pot, update all .po, compile all .mo and make the .zip ). |
| ZIPVER = -v$(shell cat metadata.json | sed '/"version"/!d' | sed s/\"version\"://g | sed s/\ //g) | ||
| endif | ||
|
|
||
| .PHONY: all clean extension potfile mergepo install install-local zip-file |
There was a problem hiding this comment.
Short: these are the target names you can explicit request, longer: I've taken a working file of an extension good looking for me and modified it according your paths.
| # The command line passed variable VERSION is used to set the version integer | ||
| # in the metadata and in the generated zip file. If no VERSION is passed, we | ||
| # won't touch the metadata version and instead use that for the zip file. | ||
| ifdef VERSION |
There was a problem hiding this comment.
Is is supposed to be set on command line ?
There was a problem hiding this comment.
Yes a shell variable, try VERSION=99 make zip-file or VERSION=99 make install and restart. The manifest isn't touched.
| ./schemas/gschemas.compiled: ./schemas/org.gnome.shell.extensions.arch-update.gschema.xml | ||
| glib-compile-schemas ./schemas/ | ||
|
|
||
| # TODO: disabled, since xgettext is not able to include prefs.xml to the pot file |
There was a problem hiding this comment.
I use this CLI :
xgettext --from-code=UTF-8 -j -o "$POTFILE" -L glade *.xml
There was a problem hiding this comment.
Thank you! I couldn't reproduce the binaries. What's your msgfmt command line?
There was a problem hiding this comment.
I use msgfmt "$pofile" -o "$mofile", no checking. In rare cases of something wrong, I let translators come back and fix it.
|
I like the simplicity of arch-update. It's clean, not complicated. I needed to test my translation. My modifications caused updating the other translations - without your scripts. I've found some inconsistencies during this process. And, I needed to know what's in the binaries, maybe a payload :-) . I'm not very familiar with GNU make, but I'm familiar with build systems in general. I've adapted this file, but I'll strip down unnecessary features. Just give me the .PHONY list and suggestions. |
|
Correct workflow would be : 1/ PR for features an d 2/ PR for translations (after I'd update the pot/po files) |
|
Great! Build systems always should make your day better :-) . But they are not programmatic like a shell script. Their goal is to handle the necessary files and steps only. A |
It's very unpleasant, inflexible and error prone to handle all the gettext files by hand. I've found some misnamed files and wrong parameters in the master branch (see the fixes in #212 ). I think it would be better to use a make or meson build.