Fix dm_only() decorator #10172
Closed
Fix dm_only() decorator #10172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the decorator to explicitly disable guild and private channel contexts - Ensured that only DM context is allowed by setting allowed_contexts.dm_channel = True
allowed_contexts.dm_channel = True was stated twice, removed the second one.
…nly decorators to explicity include allowed and unallowed contexts.
@Kenny2github Done 😎 |
|
You need to fix the linting issues, simply run black (on version 22.6 iirc) on the files that conflict to fix it. |
MysticMia
reviewed
Jun 4, 2025
discord/app_commands/commands.py
Outdated
| # Ensure that only Guild context is allowed | ||
| allowed_contexts.guild = False # Enable guild context | ||
| allowed_contexts.private_channel = False # Disable private channel context | ||
| allowed_contexts.dm_channel = False # Disable DM context |
There was a problem hiding this comment.
I think this is the only linting issue. The comment should start with a double space.
Rapptz
reviewed
Jun 20, 2025
|
This needs to run |
|
I fixed up the commit myself and pushed it. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes an issue with the
@dm_only()decorator in relation to issue #10171, where the decorator did not properly restrict commands to only DM contexts. The modification explicitly updates the allowed_contexts to ensure only the DM context is enabled and guild and private channel contexts are disabled.Checklist