Skip to content

Support commands.parameter for hybrid app commands #9894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −0
Open

Support commands.parameter for hybrid app commands #9894

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions discord/ext/commands/hybrid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,11 @@ def replace_parameters(
) -> List[inspect.Parameter]:
# Need to convert commands.Parameter back to inspect.Parameter so this will be a bit ugly
params = signature.parameters.copy()

pending_rename: Dict[str, str] = {}
pending_description: Dict[str, str] = {}
for name, parameter in parameters.items():

converter = parameter.converter
# Parameter.converter properly infers from the default and has a str default
# This allows the actual signature to inherit this property
Expand All @@ -282,6 +286,12 @@ def replace_parameters(
default = _CallableDefault(parameter.default) if callable(parameter.default) else parameter.default
param = param.replace(default=default)

if parameter.description:
pending_description[name] = parameter.description

if parameter.displayed_name:
pending_rename[name] = parameter.displayed_name

if isinstance(param.default, Parameter):
# If we're here, then then it hasn't been handled yet so it should be removed completely
param = param.replace(default=parameter.empty)
Expand All @@ -293,6 +303,12 @@ def replace_parameters(

params[name] = param

if pending_description:
app_commands.describe(**pending_description)(callback)

if pending_rename:
app_commands.rename(**pending_rename)(callback)

return list(params.values())


Expand Down