chore: Merge branch dev to main

[github-actions]

This pull request will Merge branch dev to main.

[brosssh]

The repository name should be changed to revanced-manager-downloaders , as well as the description to 🔌 ReVanced Manager Downloaders.

[Axelen123]

The -downloader suffix seems unnecessary since the downloaders are inside the downloaders folder.

[brosssh]

Should the downloader APK file name start with revanced-manager-?

[Ushie]

Yes, as it is scoped specifically for ReVanced Manager

[oSumAtrIX]

We should probably change names to a better naming convention, like:

"ReVanced Manager v1.2.3.apk" instead of "revanced-manager-v1.2.3.apk"

For downloaders, I mentioned the naming question in another place i don't remember but i pinged the relevant parties

[brosssh]

We should probably change names to a better naming convention, like:

"ReVanced Manager v1.2.3.apk" instead of "revanced-manager-v1.2.3.apk"

For downloaders, I mentioned the naming question in another place i don't remember but i pinged the relevant parties

Is this blocking merge into main? What should be the naming convention for downloaders?

[oSumAtrIX]

Personally, I would like to see the following changes:

• The term "plugin" should be removed entirely. Currently, downloaders are referred to as "plugins," but unless we have other plugins apart from downloaders, this labeling is confusing. Please remove it from the code, as well as any references in strings, documentation, etc.
• The base name should be "ReVanced Manager downloader" (or "ReVanced Manager downloaders" once multiple APKs can be supported).
• Conventionally, the name for downloaders would be something like "ReVanced Manager APKMirror downloader." However, once more options are available, the name of the APK should follow the format "ReVanced Manager downloaders," for example, "ReVanced Manager Brosssh downloaders."

Here are some issues and questions to consider:

• In our case, it would be named "ReVanced Manager ReVanced downloaders." Should we omit "ReVanced"? If we do that, should we also consider omitting "ReVanced" in "ReVanced Patches"? Not doing so would create inconsistency etc.
• Simply using "downloaders" is ambiguous. We should specify "APK downloaders." Furthermore, we need to decide on the term: should it be "app downloader," "apps downloaders," or "app downloaders"? This could also lead to longer names like "ReVanced Manager ReVanced app downloaders."
• What should we name the internal packages? Here are some possibilities:
  • app.revanced.manager.downloaders.
  • app.revanced.manager.apkdownloaders.
  • .revanced.manager.downloaders.
  • And potentially others...

[Axelen123]

The term "plugin" should be removed entirely. Currently, downloaders are referred to as "plugins," but unless we have other plugins apart from downloaders, this labeling is confusing. Please remove it from the code, as well as any references in strings, documentation, etc.

What should we name the internal packages? Here are some possibilities:

  * app.revanced.manager.downloaders.
  * app.revanced.manager.apkdownloaders.
  * .revanced.manager.downloaders.
  * And potentially others...

We had lengthy discussions while the downloader system was still in development, and I am sure this was discussed at some point. Why is this being brought up again?
I see no issue with using the word "plugin" in code or here in Manager:

I don't think these two uses are confusing. The README does not use the term "plugin" at all.

The base name should be "ReVanced Manager downloader" (or "ReVanced Manager downloaders" once multiple APKs can be supported).

Conventionally, the name for downloaders would be something like "ReVanced Manager APKMirror downloader." However, once more options are available, the name of the APK should follow the format "ReVanced Manager downloaders," for example, "ReVanced Manager Brosssh downloaders."

The two downloaders in this PR seem to be following this already.

In our case, it would be named "ReVanced Manager ReVanced downloaders." Should we omit "ReVanced"? If we do that, should we also consider omitting "ReVanced" in "ReVanced Patches"? Not doing so would create inconsistency etc.

In that situation, "ReVanced Manager official downloaders" or just "ReVanced Manager downloaders" would do.

Simply using "downloaders" is ambiguous. We should specify "APK downloaders." Furthermore, we need to decide on the term: should it be "app downloader," "apps downloaders," or "app downloaders"? This could also lead to longer names like "ReVanced Manager ReVanced app downloaders."

Downloader is not ambiguous in the context of ReVanced Manager, since it only deals with Apks.