Skip to content

ci(crowdin): init #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 115 commits into
base: compose-dev
Choose a base branch
from
Draft

ci(crowdin): init #1171

wants to merge 115 commits into from

Conversation

validcube
Copy link
Member

@validcube validcube commented Aug 28, 2023

Crowdin // CI

Moved from https://github.com/ReVanced/revanced-manager-compose/pull/91

Potentially fix: #1184

Overview

  • Crowdin Workflow will run, and create PR once every week
  • Only accept translation added to strings.xml and plurals.xml, reject incoming to translated file

TODO

  • Setup Crowdin for ReVanced Manager Compose
  • Move to Crowdin Configuration file
  • Add plurals.xml

Benefits

Can't see the image?



Benefits of using Crowdin

  • Keeping the application up-to-date with the latest translation.
  • Expand to more larger audiences like China, Japan, Spain ... and more.
  • Improving accessibility for people around the world.



Crowdin-rounded

Canny1913 and others added 30 commits January 28, 2023 02:19
* build: Update Gradle to v8.1.1

* build: Bump dependencies

* build: move repo configurations to settings

---------

Co-authored-by: Patryk Mis <[email protected]>
* feat: add Dashboard Screen and Sources Screen

* fix: fix tab onClick not working

* refactor: remove AppBar

---------

Co-authored-by: CnC-Robert <[email protected]>
* perf: obsolete sdk check

Signed-off-by: Patryk Mis <[email protected]>

* chore: bump dependencies

Signed-off-by: Patryk Mis <[email protected]>

---------

Signed-off-by: Patryk Mis <[email protected]>
Having interfaces like that is only really useful if you have unit
tests, which we don't.

Other similar compose projects don't make interfaces either.
Not having them is more readable.
based cossale

Co-authored-by: Aunali321 <[email protected]>
Axelen123 and others added 12 commits August 12, 2023 14:52
fixes an issue where GitHub Actions logs would be censored
* feat: store patched apps

* fix: missing string

* feat: save patch selection

* feat: things

* fix: fix broken query

* fix: remove redundant `withContext`

* fix: fix
This bump `actions/upload-artifact`@v2 to `actions/upload-artifact`@v3
This commit was made to allow cherry-picking the first commit of the followup commits according to https://github.com/ReVanced/revanced-manager-compose/issues/65#issue-1806335545
Draft specification of the action
@validcube validcube marked this pull request as draft August 28, 2023 15:48
@validcube validcube added the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label Aug 29, 2023
@validcube validcube requested a review from Ushie September 10, 2023 06:52
@validcube validcube marked this pull request as ready for review September 10, 2023 06:52
@oSumAtrIX
Copy link
Member

@PalmDevs One todo is unticked, is this intended?

@PalmDevs
Copy link
Member

@PalmDevs One todo is unticked, is this intended?

Why me? 😭 You meant @validcube?

@oSumAtrIX
Copy link
Member

Yes

@Ushie
Copy link
Member

Ushie commented Sep 26, 2023

@PalmDevs One todo is unticked, is this intended?

Yes, as it depends on the Crowdin Managers to work with this PR

Currently, ReVanced Manager Compose's state isn't considered "final" so I'm not sure if it's a good time to publish the strings to Crowdin for translation just yet

Maybe we can private the Crowdin and set this up until ReVanced Manager Compose releases.

@oSumAtrIX oSumAtrIX marked this pull request as draft September 26, 2023 23:43
@oSumAtrIX oSumAtrIX force-pushed the compose-dev branch 3 times, most recently from 7338157 to 70a6950 Compare May 22, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.