Skip to content

fix: "Save patched app" attempts to copy APK when patching fails #2565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2025
Merged

fix: "Save patched app" attempts to copy APK when patching fails #2565

merged 1 commit into from
May 31, 2025

Conversation

kitadai31
Copy link
Contributor

Fix the issue that this error is always thrown when patching failed.

Something went wrong:
PathNotFoundException: Cannot copy file to '/data/user/0/app.revanced.manager.flutter/files/lastPatchedApp.apk', path = '/data/user/0/app.revanced.manager.flutter/files/patcher/tmp-ESURPI/out.apk' (OS Error: No such file or directory, errno = 2)

This was caused by a bug that "Save patched app" attempts to copy the patched APK even if patching failed.

This error was generated regardless of the actual reason why the patch failed, and was adding unnecessary noise to troubleshooting.

Since this PR conflicts with #2332, please merge it first.
After that I will fix the conflict.

@kitadai31
Copy link
Contributor Author

kitadai31 commented May 27, 2025 •
edited
Loading

I believe this is the last bug left in the "Save patched app" feature

After this is merged, I think it will be time to merge the main branch
I hope it will be the last release of Flutter Manager 😄

@validcube
Copy link
Member

🥞 Thanks

@validcube
Copy link
Member

I believe this is the last bug left in the "Save patched app" feature

After this is merged, I think it will be time to merge the main branch I hope it will be the last release of Flutter Manager 😄

Let's hope. 👀

@validcube validcube merged commit bdb0317 into ReVanced:dev May 31, 2025
@validcube
Copy link
Member

Please ignore build failure notice, this is an problem when Flutter upgraded it dependency constraint. I'll push a fix soon:tm:

@kitadai31 kitadai31 deleted the fix/saving-last-patched-app-when-failed branch May 31, 2025 08:42
github-actions bot pushed a commit that referenced this pull request Jun 26, 2025
@semantic-release-bot
chore(release): 1.25.0-dev.2 [skip ci]
b6b8f4e 
# [1.25.0-dev.2](v1.25.0-dev.1...v1.25.0-dev.2) (2025-06-26)

### Bug Fixes

* "Save patched app" attempts to copy APK when patching fails ([#2565](#2565)) ([bdb0317](bdb0317))
* Nearly all rare cases of GPU renderer issues, and allow building on manager again ([#2602](#2602)) ([21ceada](21ceada))
* Obscure Flutter Impeller renderer bugs ([a5e909c](a5e909c))
github-actions bot pushed a commit that referenced this pull request Jun 27, 2025
@semantic-release-bot
chore(release): 1.25.0 [skip ci]
875ce64 
# [1.25.0](v1.24.0...v1.25.0) (2025-06-27)

### Bug Fixes

* "Save patched app" attempts to copy APK when patching fails ([#2565](#2565)) ([bdb0317](bdb0317))
* Correct supported required patch option types  ([#2475](#2475)) ([cde3f8d](cde3f8d))
* Crash using when Integer type in Patch Options ([#2453](#2453)) ([05575cc](05575cc))
* Fix installation being cancelled at installation by not prematurely deleting patched APK  ([#2490](#2490)) ([dedcb3c](dedcb3c))
* Log errors and warnings when compiling resources ([5c7d52c](5c7d52c))
* Nearly all rare cases of GPU renderer issues, and allow building on manager again ([#2602](#2602)) ([21ceada](21ceada))
* Obscure Flutter Impeller renderer bugs ([a5e909c](a5e909c))
* Unable to Share Logs due to missing ProGuard rules ([#2474](#2474)) ([915ec0e](915ec0e))
* Use device locale for app language (Default to English) ([#2488](#2488)) ([3074766](3074766))
* Use device locale when no preference is set ([#2483](#2483)) ([f79aa9e](f79aa9e))

### Features

* Add toggle to use pre-releases ([#2485](#2485)) ([89b48ce](89b48ce))
@beerpormpang
Copy link

Something went wrong:
PathNotFoundException: Cannot copy file to '/data/user/0/app.revanced.manager.flutter/files/lastPatchedApp.apk', path = '/data/user/0/app.revanced.manager.flutter/files/patcher/tmp-ESURPI/out.apk' (OS Error: No such file or directory, errno = 2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kitadai31 @validcube @beerpormpang