-
-
Notifications
You must be signed in to change notification settings - Fork 868
fix: Use system background colour for V-shaped outline #2635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: compose-dev
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
The resulting icon is not present here: https://github.com/ReVanced/revanced-branding/blob/main/assets/revanced-logo Although this doesn't go against the ReVanced Branding guidelines, if ReVanced plans to officially use that variation of dark V and colored diamond, it should be added there. Otherwise it might be better fitting to use a different variation that is better fitting |
Should that dynamic icon be in the branding guidelines? I don't see the reason to include it as this is specific to ReVanced Manager. As for the colour, I'm not sure what colour attribution to use because using text doesn't make sense, and background colour is not inverse. But these are value made likely for the material design era so it's highly likely that the black colour is #0, and white is #f2f2f2 |
The branding icons include a light and dark variant for each design except seemingly the one with the colorful diamond, maybe that was intentional? Or it's not and it was just forgotten cc @oSumAtrIX |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This should be fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, icon has been fixed as well as splash art.
You can use the shape variant with a background just fine |
Can this be merged? Should the splash art be used with a background instead? |
On second thoughts, I like the idea of having a splash art use with a background. cc: reviewers @Axelen123 do you have any objections? |
I don't have any objections to that |
Fix one of the problem on #1191 about ReVanced logo (V-shape) is hardly seen in light mode.