-
-
Notifications
You must be signed in to change notification settings - Fork 868
build: Spotless formatter #2638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: compose-dev
Are you sure you want to change the base?
Conversation
A consensus agreement about code styling has to be discussed first. As of right now, I've set it to Google style. |
Use ktlint only. Also, if this is added, this should be added to all eligible repos. In general any change to ci or build system should be applied to all applicable repos |
Resolved, switched from ktfmt to ktlint, the configuration is based on Android Studio |
.editorconfig
Outdated
ktlint_annotation_handle_annotations_with_parameters_same_as_annotations_without_parameters = [unset] | ||
ktlint_argument_list_wrapping_ignore_when_parameter_count_greater_or_equal_than = 8 | ||
ktlint_chain_method_rule_force_multiline_when_chain_operator_count_greater_or_equal_than = 4 | ||
ktlint_class_signature_rule_force_multiline_when_parameter_count_greater_or_equal_than = unset | ||
ktlint_code_style = android_studio | ||
ktlint_enum_entry_name_casing = upper_or_camel_cases | ||
ktlint_function_naming_ignore_when_annotated_with = [unset] | ||
ktlint_function_signature_body_expression_wrapping = default | ||
ktlint_function_signature_rule_force_multiline_when_parameter_count_greater_or_equal_than = unset | ||
ktlint_ignore_back_ticked_identifier = false | ||
ktlint_property_naming_constant_naming = screaming_snake_case | ||
max_line_length = 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spacing here looks cursed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, I pasted the configuration from ktlint generator and android studio wrongly formatted it to this abomination.
Fix #2423
Caution
DO NOT MERGE
This PR will basically make tons of merge conflicts. (indirectly)