Skip to content

fix(YouTube - Settings): Back button/gesture closes search instead of exiting #5418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 13, 2025
Merged

fix(YouTube - Settings): Back button/gesture closes search instead of exiting #5418

merged 7 commits into from
Jul 13, 2025
+104 −32

Conversation

MarcaDian
Copy link
Contributor

@MarcaDian MarcaDian commented Jul 11, 2025 •
edited
Loading

This PR includes the following fixes:

  • The search bar now closes on first back press; pressing back again returns to the previous screen.
  • The search bar closes when navigating to a submenu.
  • The ReVanced settings screen now retains its state when the orientation changes.

@MarcaDian MarcaDian changed the base branch from main to dev July 11, 2025 20:45
@MarcaDian
Copy link
Contributor Author

MarcaDian commented Jul 12, 2025 •
edited
Loading

Last commit solves the problem for me #5299, but tests are needed.
This is the fastest solution, but not reliable.

@LisoUseInAIKyrios LisoUseInAIKyrios linked an issue Jul 12, 2025 that may be closed by this pull request
bug(YouTube - Settings): Screen rotation change bug #5299
Closed
3 tasks
@MarcaDian
Copy link
Contributor Author

I also want to change this view when search bar is active in landscape

Screenshot_2025-07-12-10-16-17-244_app.revancede.android.youtube.jpg

@LisoUseInAIKyrios
Copy link
Contributor

Change it how? Fix the layout?

@MarcaDian
Copy link
Contributor Author

When I tried to implement search via EditText this was its default behavior, and I somehow disabled it then.

Since SearchView has a built-in EditText I think this behavior can also be disabled.

@MarcaDian
Copy link
Contributor Author

Fixed.
Screenshot_2025-07-12-11-05-31-788_app.revancede.android.youtube.jpg

We may need to implement a two-column landscape layout for ReVanced settings in the future.

Screenshot_2025-07-12-11-06-05-418_app.revancede.android.youtube.jpg

@MarcaDian

This comment was marked as resolved.

Sign in to view
@MarcaDian
Copy link
Contributor Author

^ This is necessary because the search history layout does not adapt after changing orientation.

@0xrxL
Copy link

0xrxL commented Jul 12, 2025

👉 MarcaDian for design team 👈

@LisoUseInAIKyrios
Copy link
Contributor

Anything left to do before merging?

@MarcaDian
Copy link
Contributor Author

From my side, everything works as it should.

@LisoUseInAIKyrios LisoUseInAIKyrios merged commit 134b278 into ReVanced:dev Jul 13, 2025
1 check passed
@oSumAtrIX
Copy link
Member

I accidentally didn't submit the pending comments i made

github-actions bot pushed a commit that referenced this pull request Jul 13, 2025
@semantic-release-bot
chore: Release v5.31.2-dev.4 [skip ci]
cc42efb 
## [5.31.2-dev.4](v5.31.2-dev.3...v5.31.2-dev.4) (2025-07-13)

### Bug Fixes

* **YouTube - Settings:** Back button/gesture closes search instead of exiting ([#5418](#5418)) ([134b278](134b278))
@oSumAtrIX
Copy link
Member

Screenshot_20250713-125908.png

And i don't even know how to from the app.

@MarcaDian MarcaDian mentioned this pull request Jul 13, 2025
Merged
@MarcaDian MarcaDian deleted the fix-back-gesture branch July 13, 2025 13:26
github-actions bot pushed a commit that referenced this pull request Jul 14, 2025
@semantic-release-bot
chore: Release v5.31.2 [skip ci]
7e9bb85 
## [5.31.2](v5.31.1...v5.31.2) (2025-07-14)

### Bug Fixes

* **Spotify - Spoof client:** Fix login failing by spoofing login request in addition ([#5448](#5448)) ([4e59ddc](4e59ddc))
* **YouTube - Disable double tap actions:** Remove old incompatible targets ([857053e](857053e))
* **YouTube - Hide layout components:** Hide quick actions does not work ([#5423](#5423)) ([9c66729](9c66729))
* **YouTube - Hide layout components:** Show correct custom header logo if 'Hide YouTube Doodles' is enabled ([#5431](#5431)) ([20cc141](20cc141))
* **YouTube - Settings:** Back button/gesture closes search instead of exiting ([#5418](#5418)) ([134b278](134b278))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NBruderman NBruderman NBruderman left review comments

@oSumAtrIX oSumAtrIX oSumAtrIX left review comments

@LisoUseInAIKyrios LisoUseInAIKyrios LisoUseInAIKyrios left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(YouTube - Settings): Screen rotation change bug
5 participants
@MarcaDian @LisoUseInAIKyrios @0xrxL @oSumAtrIX @NBruderman