Skip to content

feat(YouTube): Add player button to change video quality #5435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

MarcaDian
Copy link
Contributor

Closes #2027

Adds a video quality change button that changes depending on the selected quality (LHD | HD | FHD | QHD | 4K).

There is also a suggestion to create a "Player buttons" submenu in the "Player" menu, where all the player button settings would be moved.

@LisoUseInAIKyrios LisoUseInAIKyrios linked an issue Jul 13, 2025 that may be closed by this pull request
3 tasks
@MarcaDian
Copy link
Contributor Author

MarcaDian commented Jul 13, 2025

@MarcaDian MarcaDian marked this pull request as draft July 13, 2025 10:39
@MarcaDian
Copy link
Contributor Author

There are a lot of bugs. Let's wait for another solution.

@MarcaDian MarcaDian closed this Jul 13, 2025
@LisoUseInAIKyrios
Copy link
Contributor

What bugs? List all issues so it's evident what's needed to bring this to finish

@MarcaDian
Copy link
Contributor Author

MarcaDian commented Jul 13, 2025

  1. Some videos have different video quality indices, so the quality button doesn't apply the selected value until the quality is changed manually via the dialog or the dropdown menu.

  2. If "Auto" is selected in the settings, the dialog does not appear because the quality list has not been initialized yet. This issue might have appeared after I removed the "Auto" option from the list of available video qualities.

  3. The video quality list does not include frame rate values (e.g., 50, 60), which is due to outdated code used to retrieve the list of qualities.

Adding a video quality selection button is very simple - the idea was to update the button depending on the selected quality. By the way this works, but not the way I want it to.
I can't fix all the bugs on my own, and it might take a long time to get help, so this PR might stay open for a while waiting for support.
If you can help, the PR can be reopened.

Screenshot_2025-07-14-00-34-34-510_app.revancede.android.youtube.jpg

Screenshot_2025-07-14-00-38-16-416_app.revancede.android.youtube.jpg

Screenshot_2025-07-14-00-34-59-455_app.revancede.android.youtube.jpg

Screenshot_2025-07-14-00-35-09-351_app.revancede.android.youtube.jpg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants