refactor(YouTube - Settings): Using an overlay to show search results #5685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# [5.32.0-dev.1](ReVanced/revanced-patches@v5.31.3-dev.1...v5.32.0-dev.1) (2025-07-16) ### Features * **Prime Video:** Add `Playback speed` patch ([#5444](ReVanced/revanced-patches#5444)) ([22cf313](ReVanced/revanced-patches@22cf313))
# [5.32.0-dev.2](ReVanced/revanced-patches@v5.32.0-dev.1...v5.32.0-dev.2) (2025-07-23) ### Bug Fixes * **YouTube - Hide layout components:** Fix "Hide ticket shelf" ([#5516](ReVanced/revanced-patches#5516)) ([3b85c71](ReVanced/revanced-patches@3b85c71))
…rnal downloader package (#5504) Co-authored-by: LisoUseInAIKyrios <[email protected]>
# [5.32.0-dev.3](ReVanced/revanced-patches@v5.32.0-dev.2...v5.32.0-dev.3) (2025-07-24) ### Features * **YouTube - External downloads:** Improve the selection of the external downloader package ([#5504](ReVanced/revanced-patches#5504)) ([5de9aa9](ReVanced/revanced-patches@5de9aa9))
# [5.32.0-dev.4](ReVanced/revanced-patches@v5.32.0-dev.3...v5.32.0-dev.4) (2025-07-25) ### Bug Fixes * **Messenger - Hide inbox ads:** Support the latest app version ([2959c02](ReVanced/revanced-patches@2959c02))
# [5.32.0-dev.5](ReVanced/revanced-patches@v5.32.0-dev.4...v5.32.0-dev.5) (2025-07-26) ### Features * **YT Music:** Support latest versions ([#5524](ReVanced/revanced-patches#5524)) ([551dcf0](ReVanced/revanced-patches@551dcf0))
# [5.32.0](ReVanced/revanced-patches@v5.31.2...v5.32.0) (2025-07-27) ### Bug Fixes * **Messenger - Hide inbox ads:** Support the latest app version ([2959c02](ReVanced/revanced-patches@2959c02)) * **YouTube - Hide layout components:** Fix "Hide ticket shelf" ([#5516](ReVanced/revanced-patches#5516)) ([3b85c71](ReVanced/revanced-patches@3b85c71)) * **YouTube - GmsCore support:** Fix search suggestions when logged out by using correct search provider ([#5483](ReVanced/revanced-patches#5483)) ([e86fdc8](ReVanced/revanced-patches@e86fdc8)) ### Features * **Prime Video:** Add `Playback speed` patch ([#5444](ReVanced/revanced-patches#5444)) ([22cf313](ReVanced/revanced-patches@22cf313)) * **YouTube - External downloads:** Improve the selection of the external downloader package ([#5504](ReVanced/revanced-patches#5504)) ([5de9aa9](ReVanced/revanced-patches@5de9aa9)) * **YT Music:** Support latest versions ([#5524](ReVanced/revanced-patches#5524)) ([551dcf0](ReVanced/revanced-patches@551dcf0))
# [5.33.0-dev.1](ReVanced/revanced-patches@v5.32.0...v5.33.0-dev.1) (2025-07-28) ### Features * **YouTube - Playback speed:** Add "Restore old playback speed menu" option ([#5552](ReVanced/revanced-patches#5552)) ([b01f15b](ReVanced/revanced-patches@b01f15b))
# [5.33.0-dev.2](ReVanced/revanced-patches@v5.33.0-dev.1...v5.33.0-dev.2) (2025-07-29) ### Features * **ORF ON:** Add `Remove root detection` patch ([#5551](ReVanced/revanced-patches#5551)) ([6c6aa35](ReVanced/revanced-patches@6c6aa35))
# [5.33.0-dev.3](ReVanced/revanced-patches@v5.33.0-dev.2...v5.33.0-dev.3) (2025-07-30) ### Bug Fixes * **YouTube - Playback speed:** Use old speed menu for player button if enabled ([1e8f436](ReVanced/revanced-patches@1e8f436))
# [5.33.0-dev.4](ReVanced/revanced-patches@v5.33.0-dev.3...v5.33.0-dev.4) (2025-07-30) ### Performance Improvements * **YouTube:** Filter identifier callback only on root component creation ([#5558](ReVanced/revanced-patches#5558)) ([ccac46e](ReVanced/revanced-patches@ccac46e))
...utube/src/main/java/app/revanced/extension/youtube/settings/search/SearchResultsAdapter.java
Outdated
Show resolved
Hide resolved
MarcaDian
force-pushed
the
fix-animation
branch
from
810a90c to
8cbfdd2
Compare
…nections that initially can use -1 quality index
## [5.35.1-dev.1](ReVanced/revanced-patches@v5.35.0...v5.35.1-dev.1) (2025-09-11) ### Bug Fixes * **Duolingo - Disable ads:** Support latest app target ([#5782](ReVanced/revanced-patches#5782)) ([8491516](ReVanced/revanced-patches@8491516)) * **YouTube - Hide layout components:** Hide new type of Playable shelf ([3af4126](ReVanced/revanced-patches@3af4126))
This comment has been minimized.
This comment has been minimized.
# [5.36.0-dev.1](ReVanced/revanced-patches@v5.35.1-dev.1...v5.36.0-dev.1) (2025-09-12) ### Features * **YouTube - SponsorBlock:** Add 'Hook' segment category ([#5783](ReVanced/revanced-patches#5783)) ([2e042c4](ReVanced/revanced-patches@2e042c4))
# Conflicts: # extensions/youtube/src/main/java/app/revanced/extension/youtube/settings/Settings.java
|
Due to a DMCA takedown notice, the PR was closed, as a force push was needed to comply. If applicable, the PR may be reopened. |
|
@MarcaDian I cannot force push the rebased branch, because this PR is closed. Either open a new PR and I'll force push. Or rebase on the latest upstream dev (and pick 'accept theirs' to each conflict). |
|
I'm a little confused about what's going on, although I saw the message on reddit. I saved a copy locally. |
|
Yes repo is just fine. Copy your local directory before pulling any changes. I think I have everything correct but keep a copy just in case. |
This comment was marked as resolved.
This comment was marked as resolved.
|
I think it's still using the old dev branch. Fetch remote, checkout upstream/dev, create a new branch, and create an empty pull request. I'll try pushing the rebased branch I have to you. |
|
Moved to #5806 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way search results are displayed. Instead of manipulating preferences (removing - adding), we use another overlay on top of the settings that shows search results.
This solves the problem of old preference APIs where adding/removing preferences breaks their listeners. (#5439 (comment)).
Refactored some utility methods and moved them to outer classes to avoid code duplication and enable reuse in other apps.
When searching for a disabled child setting, its parent setting is shown above it.
Tap on the path opens a screen containing this setting.
Long-press a search result to scroll directly to the setting.
Added
slide_out_bottomanimation to custom video quality and playback speed dialogs.Search results are limited to 50 items.
Added search history screen instead of dropdown list.
Added "Search Tips" section to the search history screen to highlight some non-obvious features for the user.