feat(YouTube Music): Add in app settings menu

[MarcaDian]

Adds settings to YouTube Music.

A continuation and completion of #2708

[MarcaDian]

I just made a working version of the settings because the question of music settings came up #5813 (comment) , #2708 (comment).

I'm not very knowledgeable about such things, especially when the abstraction affects important components.

[oSumAtrIX]

Abstraction means you should reuse existing code by creating a base function that you call everywhere you need. Or you use the existing one. See the YouTube settings patch as reference

[LisoUseInAIKyrios]

I'm surprised this works with changes to only 10 files.

At first glance it looks like there's a small amount of code duplication, but that should be easy to consolidate.

[MarcaDian]

A little later I will implement an abstract class for the toolbar.

But with bytecode it's not up to me)

[MarcaDian]

Some changes will probably break something in #5806, but after it's merged we can also easily add search in the music settings, although there will probably be few settings there.

[oSumAtrIX]

Abstraction should automatically handle this. If you reuse the code, then if you implement the settings patch for music, it will inherit the code for search. If you dont want it to appear dynamically you can add an if (settings.count < X) check or control it by a super class/function parameter

[MarcaDian]

Search is not abstract now.

In order not to do two meaningless jobs, must first merge PR with search, and adapt it to music, or vice versa, first merge music settings, and then adapt search PR.

[LisoUseInAIKyrios]

Lets merge this first because it's simpler.

I don't think search is needed for YT Music because it's going to be like 5 settings (currently only 1 exists).

[LisoUseInAIKyrios]

Although, maybe merge the other first because it's basically ready.

This needs to add at least a few settings and optionally an about screen to make it complete.

[MarcaDian]

Can we use existing strings from YouTube or do need to create our own for the music?

Edit: Although this probably won't work due to the implementation of adding strings via the app id.

[LisoUseInAIKyrios]

The app id is just a string.
There already is a shared string bundle, and settings strings can go there.

revanced-patches/patches/src/main/resources/addresources/values/strings.xml

Line 21 in 105f6e0

<app id="shared">

revanced-patches/patches/src/main/resources/addresources/values/strings.xml

Line 33 in 105f6e0

<patch id="misc.settings.settingsResourcePatch">

[MarcaDian]

I spoke about ads strings for example.

Nevermind, I've already made a settings template. But I'll need help filling it out.

[MarcaDian]

My English is not very good, so please correct me.

[ILoveOpenSourceApplications]

Oh hell nah, not the gray separators!. Please do remove them.

[MarcaDian]

Oh hell nah, not the gray separators!. Please do remove them.

This is not so important yet, but if you noticed, they are also in the regular settings.

These settings are still copying the standard ones. I still don't understand why such a popular app has such outdated code in the settings.

[ILoveOpenSourceApplications]

This is not so important yet, but if you noticed, they are also in the regular settings.

It's not there atleast in the main menu for now.

These settings are still copying the standard ones. I still don't understand why such a popular app has such outdated code in the settings.

I agree. Maybe a theme option in the future can address this issue and remove them or change the theme perhaps.

[MarcaDian]

I don't think there's anything to test here, everything is working as it should for now.

By the way, I thought there would be an option in the settings to change video stream clients?

[LisoUseInAIKyrios]

Yeah can add a spoof stream client type, even though there isn't a good reason to change it.

Can merge today/tomorrow then.

[LisoUseInAIKyrios]

Ready to merge?

[MarcaDian]

Does this have to be lowercase?
So I googled it and it's correct.

Otherwise ok.

[LisoUseInAIKyrios]

It would be ideal if there's a ReVanced language setting like YT. The strings and setting are already shared, but it needs a patch change similar YT so the ReVanced modified context is used for the settings UI.

revanced-patches/patches/src/main/kotlin/app/revanced/patches/youtube/misc/settings/SettingsPatch.kt

Line 239 in 105f6e0

// Add attachBaseContext method to override the context for setting a specific language.

But that can wait until later, especially since there's so few settings and the translations have improved a lot.

[MarcaDian]

The only thing I want to see in Music right now is a setting to hide the Cast button. Now can try to add that.

Maybe with the implementation of settings in Music, more devs will start supporting this product.

It seems to me that YouTube Music is being unfairly ignored for now.