Skip to content

Include early_close_fee for loan_schedule_reset #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikhilvangumallarc wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Include early_close_fee for loan_schedule_reset #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
10118a9
Reset Loan Schedule
SamuelNittala Jul 13, 2021
a9c4bf6
Merge branch 'master' of https://github.com/RedCarpetUp/ledger into l…
SamuelNittala Jul 13, 2021
0791b87
Import error fix
SamuelNittala Jul 13, 2021
2cd4506
Black format fix
SamuelNittala Jul 13, 2021
d5b57c4
Added test-case for emi payment reset
SamuelNittala Jul 13, 2021
87c6cf6
ct
SamuelNittala Jul 13, 2021
3c9bdd8
Fixed test-case
SamuelNittala Jul 14, 2021
be19342
Type fix
SamuelNittala Jul 14, 2021
e9a9f1e
Added dpd check
SamuelNittala Jul 14, 2021
7eb1ed1
Bill level tests
SamuelNittala Jul 14, 2021
a4c791b
Remove unused imports, added principal_due test
SamuelNittala Jul 15, 2021
388da3f
Format fix and name change
SamuelNittala Jul 15, 2021
a63af9b
Added individual file testing to README
SamuelNittala Jul 16, 2021
c7e2265
Fixed pytest.ini
SamuelNittala Jul 16, 2021
7a72bb5
Added extend schedule test and improvements to rest_loan_schedule
SamuelNittala Jul 16, 2021
80c55a7
Merge branch 'master' into loan-schedule-reset
nikhilvangumallarc Jul 24, 2021
0b62352
include early_close_fee for loan_schedule_reset
nikhilvangumallarc Jul 24, 2021
f45e53c
call slide_payment_to_emis for early close fee after it has been handled
nikhilvangumallarc Aug 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/rush/loan_schedule/loan_schedule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,8 +385,6 @@ def make_emi_payment_mappings_inactive(user_loan: Loan, session: Session) -> Non
.update({PaymentMapping.row_status: "inactive"}, synchronize_session=False)
)

user_loan = get_user_loan(session=session, loan_id=user_loan.loan_id)

# returning if the loan is extended, because we don't have context of past tenure.
is_loan_extended = (
session.query(LedgerTriggerEvent.loan_id)
Expand All @@ -408,7 +406,7 @@ def make_emi_payment_mappings_inactive(user_loan: Loan, session: Session) -> Non
.filter(
PaymentSplit.payment_request_id
== LedgerTriggerEvent.extra_details["payment_request_id"].astext,
PaymentSplit.component.in_(("principal", "interest", "unbilled")),
PaymentSplit.component.in_(("principal", "interest", "unbilled", "early_close_fee")),
LedgerTriggerEvent.name == "payment_received",
LedgerTriggerEvent.loan_id == user_loan.loan_id,
)
Expand Down
2 changes: 2 additions & 0 deletions src/rush/payments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,8 @@ def adjust_payment(
# The amount to adjust is computed for this bill. It should all settle.
assert remaining_amount == 0
slide_payment_to_emis(user_loan, event, data["amount_to_adjust"])
if data["type"] == "early_close_fee":
slide_payment_to_emis(user_loan, event, data["amount_to_adjust"])
amount_to_adjust -= data["amount_to_adjust"]

# After doing the sliding we check if the loan can be closed.
Expand Down