-
Notifications
You must be signed in to change notification settings - Fork 52
add new version pg_repack #2052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
539733e to
2ed4849
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2052 +/- ##
==========================================
+ Coverage 65.50% 65.55% +0.05%
==========================================
Files 56 56
Lines 6618 6640 +22
==========================================
+ Hits 4335 4353 +18
- Misses 2283 2287 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cc5521f to
c382bdb
Compare
|
/retest |
1 similar comment
|
/retest |
c382bdb to
f131a13
Compare
jdobes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it's looking good, the conatiner build time in Konflux doesn't seem to be any longer.
Just few notes:
- I'd probably not create another build stage in Dockerfile, but add it to the existing one. But it's a minor thing, if there is some benefit to have it separately, I'm okay with it
- The problem with downloading external files, adding it to Konflux hermetic build artifact yaml, asking for exceptions, etc. We haven't got the exception yet and even when we get it, it's probably going to be temporary. So I'd propose to use git submodules instead of downloading archives. This git submodule would reference specific version from pg_repack github repo and during Konflux build it'd be obtained during
git clonephase. No need for exceptions and artifact download.
RHINENG-21738
f131a13 to
5fa8087
Compare
Secure Coding Practices Checklist GitHub Link
Secure Coding Checklist