Skip to content

Conversation

@RostyslavKachan
Copy link
Collaborator

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@RostyslavKachan RostyslavKachan force-pushed the master branch 21 times, most recently from 539733e to 2ed4849 Compare November 21, 2025 13:42
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.55%. Comparing base (c8f54d0) to head (5371778).
⚠️ Report is 30 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2052      +/-   ##
==========================================
+ Coverage   65.50%   65.55%   +0.05%     
==========================================
  Files          56       56              
  Lines        6618     6640      +22     
==========================================
+ Hits         4335     4353      +18     
- Misses       2283     2287       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RostyslavKachan RostyslavKachan force-pushed the master branch 6 times, most recently from cc5521f to c382bdb Compare November 24, 2025 14:40
@RostyslavKachan
Copy link
Collaborator Author

/retest

1 similar comment
@RostyslavKachan
Copy link
Collaborator Author

/retest

@RostyslavKachan RostyslavKachan changed the title test new version pg_repack add new version pg_repack Nov 26, 2025
Copy link
Member

@jdobes jdobes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it's looking good, the conatiner build time in Konflux doesn't seem to be any longer.

Just few notes:

  1. I'd probably not create another build stage in Dockerfile, but add it to the existing one. But it's a minor thing, if there is some benefit to have it separately, I'm okay with it
  2. The problem with downloading external files, adding it to Konflux hermetic build artifact yaml, asking for exceptions, etc. We haven't got the exception yet and even when we get it, it's probably going to be temporary. So I'd propose to use git submodules instead of downloading archives. This git submodule would reference specific version from pg_repack github repo and during Konflux build it'd be obtained during git clone phase. No need for exceptions and artifact download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants