Skip to content

Add Firebase Messaging #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add Firebase Messaging #765

wants to merge 7 commits into from

Conversation

Freydoonk
Copy link

According to the changes of Google I change the PushSharp to work with FCM.
Firebase Cloud Messaging (FCM) is the new version of GCM. It inherits the reliable and scalable GCM infrastructure, plus new features!

@ForNeVeR
Copy link
Contributor

ForNeVeR commented Nov 10, 2016

Why did you reformat all the code? It sufficiently complicates the merge of your contribution.

@Freydoonk
Copy link
Author

@ForNeVeR I do this to remove the extra using and convert space character to tab. It is the standard of code style that I used.

@ForNeVeR
Copy link
Contributor

ForNeVeR commented Nov 11, 2016

@Freydoonk just a suggestion: it's rarely acceptable to reformat the open source project code in scope of any PR without talking with maintainer first. It may be the code style you use, but it's definitely not the code style that's used in PushSharp codebase.

And that's not nice that you were converting the code style and updating some project settings in a single commit. Generally it's better to always completely split the formatting changes to another commit or even a separate PR. That will allow the maintainer to cherry-pick only the changes he want to include in the project.

@Freydoonk
Copy link
Author

@ForNeVeR You are right, I consider your notice in future

@fproulx-pbox
Copy link

What's missing for this to be considered for merging to master ?
I would really like to use FireBase ASAP.

@h3smith
Copy link

h3smith commented Nov 16, 2016

No one is ever going to merge a request that changes every single file and every single line of virtually every single file.

The pull request has to have only the relevant changes, not formatting changes as stated above.

@ForNeVeR
Copy link
Contributor

@fproulx-pbox actually you already can use FCM with PushSharp, see #752.

@knopa
Copy link

knopa commented Oct 25, 2017

When be the nuget package?

@jilnesta
Copy link

jilnesta commented Jun 1, 2018

When it available on the nuget package ? pls :((

@JotaBritoDev
Copy link

JotaBritoDev commented Jan 18, 2019

firebase
(https://developers.google.com/cloud-messaging/http-server-ref)

Could someone look ahead for this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants