Merged
Conversation
Contributor
I guess it doesn't hurt us... It might need to be public for frooxengine to use it? Not sure, haven't looked into it.
Yea, that would make sense. At least in the current state I don't see anyone using it, but we might have to think about how to get that done. I kinda want to avoid adding anything to the data model with mods. |
Banane9
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if we need to include the ExecutionHook (it is public so technically we should but who would ever use it?)
I have included the ModLoaderSettings stuff but commented it out. I tried to get it to work but it would always throw errors, probably because we are not being loaded as a plugin.