Make ReLU-QP woring on CPU #5
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that some operations in the current code fail when running without a CUDA-enabled GPU.
Timing: The implementation used
torch.cuda.Event
, which only works with CUDA. This has been updated to use the standard Pythontime
module when CUDA is not available, ensuring correct timing on both CPU and GPU.jit_forward
method: The previous version usedtorch.matmul(W, input, out=input)
. On CPU, this causes incorrect results because the out tensor overlaps with an input operand. The fix replaces it with an assignment to a new tensor, which avoids overlapping writes.