Skip to content

fix: Accessibility issues - #814

Open
HaSistrunk wants to merge 27 commits into
developmentfrom
a11y-moderate
Open

fix: Accessibility issues#814
HaSistrunk wants to merge 27 commits into
developmentfrom
a11y-moderate

Conversation

@HaSistrunk

@HaSistrunk HaSistrunk commented Jun 17, 2026

Copy link
Copy Markdown
Member

Accessibility fixes for issues identified in internal accessibility audit, as well as some bug fixes.

For review: I would appreciate a revew particularly of the form validation changes I made. Specifically making sure the views.py updates (for accession, bagiit profile creation, and rights), the util, and the new org forms.py logic are solid.

Page titles and responsiveness

  • Standardized page titles and h1s to be unique and descriptive
  • Improved title/action button layout responsiveness
  • Shortened button labels to better adapt to zoom/text resize

Labels

  • Gave repeated button labels unique aria-labels to be more distinguishable for screen readers
  • Fixed form fields whose label wasn't correctly associated with input
  • Added a "*Required field" legend to forms

Form validation and data preservation

  • Created an aria-attrs utility to use consistently across forms so that invalid fields correctly expose aria-invalid/aria-describedby and are programmatically connected to their error and help text. Added Organizations form
  • Set novalidate on forms to use Django validation.
  • Fixed forms that were losing entered values on failed submission instead of validating the whole form and providing error messages.
  • Improved create accession form resource find/dismiss control behaviour

Focus management

  • Improved focus management for bag-it profile and rights forms with add/delete functions
  • If errors on form submit, shifted focus to the first input with an error.

@HaSistrunk
HaSistrunk deployed to development August 12, 2026 20:33 — with GitHub Actions Active
@HaSistrunk
HaSistrunk deployed to development August 13, 2026 20:31 — with GitHub Actions Active
@HaSistrunk
HaSistrunk deployed to development August 13, 2026 20:50 — with GitHub Actions Active
@HaSistrunk
HaSistrunk deployed to development August 14, 2026 15:35 — with GitHub Actions Active
@HaSistrunk
HaSistrunk marked this pull request as ready for review August 14, 2026 16:57
@HaSistrunk
HaSistrunk requested a review from helrond August 14, 2026 16:57
@helrond

helrond commented Aug 17, 2026

Copy link
Copy Markdown
Member

This looks great! Two things, both of which are more minor usability things that are not new:

  • On the BagIt-Profile detail page, I am missing an "Edit" button. In order to update it, I have to go back to the organization page and click the Edit button there. I think this form should either redirect back to the organization page (which is what the rights form does) or there should be an edit button on that view page.
  • For the Rights form, if you make a mistake while filling out the top part of the form but have also added some rights granted or restricted some unexpected things happen. I'm not 100% sure these are huge deals but:
    • If you've added just one rights granted or restricted, it does not show up but when you click on the "Add rights granted or restricted" button, that first card is pre-populated with what you'd added before.
    • If you add more than one, then all but the last one show up (I think). In this case, clicking on the "Add rights granted or restricted" button doesn't actually do anything - you don't get a new card in the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants