Skip to content

Conversation

@mdragonsrage
Copy link
Contributor

Submission Checklist

Warning

Submission Checklist
Failure to complete this checklist in its entirety will result in your Pull Request being dismissed. If you have any questions, please feel free to create an issue.

Note

Draft Pull Requests
If you are unclear about any of the rules regarding the creation of character sheets, or need assistance from the Roll20 team, please feel free to create a Draft PR and request feedback. We'd much rather provide assistance than reject a PR.

Pull Request Title

Please format your pull request in the following way: [Sheet Name] Change Type: Description. For example: [D&D5e] New Feature: Adding dragons to dungeons.

  • The pull request title clearly contains the name of the sheet I am editing.
  • The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).

Pull Request Content

  • The pull request makes changes to files in only one sub-folder.
  • The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)
  • The pull request does not, without express prior permission from affected parties, include any material that could be considered to infringe on a Publisher's intellectual property rights, such as logos, images, rules text or other rules content.

New Sheet Details

Please complete this section if you are adding a new sheet to the repository.

If you are submitting a new sheet to the repository, please fill in any empty spaces indicated by [ ].

  • The name of this game is: [ ]

    (e.g. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

  • The publisher of this game is: [ ]

    (e.g. Wizards of the Coast, Evil Hat)

  • The name of this game system/family is: [ ]

    (e.g. Dungeons & Dragons, FATE)

  • The rules for this game can be found at the following location: [ ]

    (e.g. a link to purchase, ISBN, Half-Price Books)

  • I have followed the Character Sheets Standards when building this sheet.

  • I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.

Select EXACTLY One:

  • This game is a traditionally published game.
  • This game is not a traditionally published game.
  • This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system. [ ADD DETAILS HERE ]

Changes / Description

@roll20deploy
Copy link
Contributor

Character Sheet Info Roll20 Internal Use only.

@kfroll20
Copy link
Contributor

Hello @mdragonsrage,
Thank you for providing a fix to the attribute for this sheet. As it is an official sheet that was recently added, I want to bring in the original author to give the "all clear" before merging this. Their Github account appears to be deactivated so I reached out to them on their Roll20 account. Once they can verify that this change may be merged, please mark this is a ready for review and then we can move forward.

Thank you!

@mdragonsrage mdragonsrage marked this pull request as ready for review September 26, 2025 05:34
@mdragonsrage mdragonsrage requested a review from a team as a code owner September 26, 2025 05:34
@mdragonsrage
Copy link
Contributor Author

Set as ready for review,

Thank you!

@NorWhal
Copy link
Contributor

NorWhal commented Sep 30, 2025

Hey, @mdragonsrage, could we get a summary of the problem you're trying to fix here?

@mdragonsrage
Copy link
Contributor Author

mdragonsrage commented Sep 30, 2025

Hi @NorWhal!
The AC attribute is not updating automatically when changing the values, but only after closing -> reopening the sheet.
It seems it could be due to the casing of the attribute name when uppercase are involved

@mdragonsrage
Copy link
Contributor Author

Hello! Any News?

@nmbradley
Copy link
Collaborator

Hi @mdragonsrage

We are still awaiting a response from Necrotic Gnome.

Thank you for your patience.

@mdragonsrage
Copy link
Contributor Author

No worries, thank you for the update!

@BronsonHall
Copy link
Contributor

Hey @mdragonsrage

Just letting you know this has been approved by the publisher, and we're merging this now! Thanks for your contribution!

@BronsonHall BronsonHall merged commit aac894e into Roll20:master Oct 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants