fix: improve search for period-prefixed terms like .gitignore and .rooignore #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
…oignore - Created custom SearchBar wrapper component that intercepts search queries - Automatically expands period-prefixed terms to search both with and without the period - This works around the tokenization issue where periods are stripped during indexing - Fixes RooCodeInc/Roo-Code#6508
roomote
bot
requested review from
mrubens,
cte and
hannesrudolph
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
|
|
||
| // Get the original getVal and setVal methods | ||
| const originalGetVal = autocompleteInstance.getVal.bind(autocompleteInstance); | ||
| const originalSetVal = autocompleteInstance.setVal.bind(autocompleteInstance); |
There was a problem hiding this comment.
Unused 'originalSetVal' is bound but never used; consider removing it.
Suggested change
| const originalSetVal = autocompleteInstance.setVal.bind(autocompleteInstance); |
| matches.forEach(match => { | ||
| const termWithoutPeriod = match.substring(1); // Remove the leading period | ||
| // Replace the term with an OR expression | ||
| processedQuery = processedQuery.replace( |
There was a problem hiding this comment.
Using string.replace inside a loop may cause duplicate or nested replacements if the same period-prefixed term appears more than once. Consider a global regex replacement or safeguard against re-matching replaced text.
|
Not a proper fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the search functionality for terms that start with a period (like
.gitignoreand.rooignore).Problem
The search plugin's tokenization process strips out periods from search terms during both indexing and searching, making it impossible to find documentation about
.rooignore,.gitignore, and similar period-prefixed terms.Solution
Created a custom SearchBar wrapper component that:
.gitignore)Technical Details
Testing
npm run build.rooignore,.gitignore, and other period-prefixed termsFixes RooCodeInc/Roo-Code#6508
Important
Fixes search for period-prefixed terms by expanding queries to include both original and non-period versions in a custom
SearchBarWrapper..gitignoreand.rooignoreby expanding queries to include both original and non-period versions.index.jsas a Docusaurus theme component override.SearchBarWrappercomponent wrapsOriginalSearchBarand intercepts autocomplete.processQuery()to modify queries, adding OR clauses for period-prefixed terms.MutationObserverand periodic checks to ensure interception.npm run build.This description was created by
for f3e408a. You can customize this summary. It will automatically update as commits are pushed.