fix: prevent E2BIG errors and mixed system prompts in Claude Code provider #8120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
…vider - Always pass base system prompt via --system-prompt flag on all platforms - Send only messages via stdin to avoid E2BIG errors - Ensures Claude Code replaces its default prompt instead of merging - Fixes issues with large custom instructions causing argument size limits Fixes #8117
dosubot
bot
added
size:M
| @@ -139,7 +139,7 @@ describe("runClaudeCode", () => { | |||
| expect(typeof result[Symbol.asyncIterator]).toBe("function") | |||
| }) | |||
|
|
|||
| test("should handle platform-specific stdin behavior", async () => { | |||
| test("should always pass system prompt via flag and messages via stdin", async () => { | |||
There was a problem hiding this comment.
Good update to the test name! This now accurately reflects that we're testing consistent behavior across all platforms rather than platform-specific behavior.
| args.push("--system-prompt", systemPrompt) | ||
| } | ||
| // Build args - always pass system prompt as flag to avoid mixing with Claude Code's default | ||
| const args = ["-p", "--system-prompt", systemPrompt] |
There was a problem hiding this comment.
Could we expand this comment to be more explicit about the dual purpose? Something like:
Suggested change
| const args = ["-p", "--system-prompt", systemPrompt] | |
| // Build args - always pass system prompt as flag to ensure Claude Code replaces its default prompt entirely | |
| // (avoids mixing prompts) while keeping argv small by sending messages via stdin (avoids E2BIG) |
| stdinData = JSON.stringify(messages) | ||
| } | ||
| // Prepare stdin data: only send messages to avoid E2BIG errors | ||
| // System prompt is now always passed via --system-prompt flag |
There was a problem hiding this comment.
Great simplification! These comments clearly explain the rationale. Is the os import on line 7 still needed now that we've removed the platform-specific logic?
hannesrudolph
added
the
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses Issue #8117 by fixing E2BIG errors and preventing mixed system prompts when using the Claude Code API provider.
Problem
Users were experiencing two critical issues with the Claude Code provider:
Solution
The fix implements a consistent approach across all platforms:
--system-promptflag - This ensures Claude Code replaces its default prompt entirelyChanges
runProcessfunction to always use--system-promptflag for the base system promptTesting
Impact
This fix ensures:
Fixes #8117
Important
Fixes E2BIG errors and mixed system prompts in Claude Code provider by consistently using
--system-promptflag and sending only messages via stdin.runProcessinrun.tsnow always uses--system-promptflag for system prompts, preventing mixed prompts.run.spec.tsto reflect new behavior, ensuring--system-promptis always used and only messages are sent via stdin.createClaudeCodeNotFoundError()inrun.tsfor better user guidance.This description was created by
for d4dc2eb. You can customize this summary. It will automatically update as commits are pushed.