-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat: add Kimi K2 thinking model to Fireworks AI provider #9202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review complete. Found 1 issue that needs attention.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
| "accounts/fireworks/models/kimi-k2-thinking": { | ||
| maxTokens: 16000, | ||
| contextWindow: 262144, | ||
| supportsImages: false, | ||
| supportsPromptCache: true, | ||
| inputPrice: 0.6, | ||
| outputPrice: 2.5, | ||
| cacheReadsPrice: 0.15, | ||
| supportsTemperature: true, | ||
| preserveReasoning: true, | ||
| defaultTemperature: 1.0, | ||
| description: | ||
| "The kimi-k2-thinking model is a general-purpose agentic reasoning model developed by Moonshot AI. Thanks to its strength in deep reasoning and multi-turn tool use, it can solve even the hardest problems.", | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The kimi-k2-thinking model specifies defaultTemperature: 1.0 and supportsTemperature: true, but the FireworksHandler constructor sets a blanket defaultTemperature: 0.5 for all models. This means the model-specific default temperature of 1.0 will be overridden by the handler's 0.5 default, potentially affecting the model's reasoning behavior since temperature is a critical parameter for thinking models.
Fix it with Roo Code or mention @roomote and request a fix.
|
I tried working with Kimi K2 Thinking a few days ago with Fireworks and tool calls were failing. However in testing this PR with Fireworks and Kimi K2 Thinking everything is working fine now. So either the interleave thinking issue at Fireworks was fixed or some other change in Roo also fixed the interleave tool call problems. Looking forward to this being merged into main so the rest of my team can access it. |
This PR attempts to address Issue #9201 by adding support for the Kimi K2 thinking model to the Fireworks AI provider.
Changes
accounts/fireworks/models/kimi-k2-thinkingto the FireworksModelId typeTesting
Fixes #9201
Feedback and guidance are welcome!
Important
Add
kimi-k2-thinkingmodel to Fireworks AI provider with configuration and tests.accounts/fireworks/models/kimi-k2-thinkingtoFireworksModelIdinfireworks.ts.kimi-k2-thinkingmodel infireworksModelswith parameters likemaxTokens,contextWindow,supportsPromptCache, etc.fireworks.spec.tsto verifykimi-k2-thinkingmodel configuration.This description was created by
for 811c732. You can customize this summary. It will automatically update as commits are pushed.