fix: prevent duplicate tool_result blocks in native tool protocol #9248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XL
Contributor
Review complete - no issues found. This PR successfully addresses the duplicate tool_result block issue in native tool protocol. The implementation correctly tracks whether a tool result has been pushed and prevents duplicate calls, which was causing 400 errors from Anthropic's API. The changes are well-tested with comprehensive test coverage for both the duplicate prevention and the mode-based tool filtering. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
daniel-lxs
force-pushed
the
fix/native-tool-calls-duplicate-results
branch
from
e533e82 to
231bade
Compare
dosubot
bot
added
size:S
mrubens
approved these changes
Nov 13, 2025
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
hannesrudolph
added
the
Issue/PR - Triage
hannesrudolph
added
PR - Needs Review
and removed
Issue/PR - Triage
mrubens
approved these changes
Nov 15, 2025
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 400 error when tool execution fails with native tool calls enabled.
The issue occurred when both handleError and the tool's result handler called pushToolResult, creating duplicate tool_result blocks with the same tool_use_id. Anthropic's API rejects this as invalid.
Added hasToolResult flag to track and prevent duplicate results per tool call in native protocol mode.