Skip to content

replacing deprecated Nan:MakeCallback with Nan::AsyncResource #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

replacing deprecated Nan:MakeCallback with Nan::AsyncResource #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion authenticate_pam.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ void after_doing_auth(uv_work_t* req, int status) {
args[0] = Nan::New<String>(m->errorString.c_str()).ToLocalChecked();
}

Nan::MakeCallback(Nan::GetCurrentContext()->Global(), Nan::New(m->callback), 1, args);
Nan::AsyncResource *asyncResource = new Nan::AsyncResource("callback");
Copy link
Owner

@Rush Rush Oct 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a clean change ... but my question is what is calling delete on asyncResource ?

Copy link
Owner

@Rush Rush Oct 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without delete we might have a memory leak.

Copy link
Contributor Author

@artynet artynet Oct 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you 100% sure that the new NAN APIs and node 12 won't take care of it ? do you have some sort of setup to run some tests....or at least tell me how to do it ?

Copy link
Owner

@Rush Rush Oct 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could test it by running the code in debug mode and with valgrind to check for memory leaks.

asyncResource->runInAsyncScope(Nan::GetCurrentContext()->Global(), Nan::New(m->callback), 1, args);

m->callback.Reset();

Expand Down