Handle link_name attribute
#4031
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also makes some tweaks to how we handle the no_mangle attribute. gcc/rust/ChangeLog: * backend/rust-compile-base.cc: Include "rust-gcc.h". (should_mangle_item): Remove function. (get_unmangled_item): Add function. (HIRCompileBase::setup_fndecl): Remove handling of no_mangle. (HIRCompileBase::handle_no_mangle_attribute_on_fndecl): Remove function definition. (HIRCompileBase::compile_function): Use get_unmangled_name instead of should_mangle_name. * backend/rust-compile-base.h (HIRCompileBase::handle_no_mangle_attribute_on_fndecl): Remove function declaration. * util/rust-attribute-values.h (Attributes::LINK_NAME): New constexpr member variable. * util/rust-attributes.cc (__definitions): Add LINK_NAME. Signed-off-by: Owen Avery <[email protected]>
|
Fixes #3867 |
philberty
requested changes
Aug 1, 2025
|
Also you should put the Fixes into the commit message too since this is almost it finished |
P-E-P
reviewed
Aug 4, 2025
|
|
||
| if (input->get_attr_input_type () | ||
| != AST::AttrInput::AttrInputType::LITERAL) | ||
| goto err_link_name; |
There was a problem hiding this comment.
Not a fan of this goto. You could have split the code in multiple functions and I don't want newcomers to grep the codebase, find this goto and sprinkle some everywhere nor be confused about it.
There was a problem hiding this comment.
good catch yeah avoid goto's please
|
Now depends on #4044 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless I'm mistaken, we don't need to put
no_mangleinDECL_ATTRIBUTES (fndecl), right? Since we do all of the mangling, and gcc doesn't seem to have ano_mangleattribute?