Vendor libcore 1.49
#4060
Draft
Vendor libcore 1.49
#4060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contrib/ChangeLog: * gcc-changelog/git_commit.py (ignored_prefixes): Add 'libgrust/libcore/'. Signed-off-by: Owen Avery <[email protected]>
|
Note that this PR leaves usage of |
This commit vendors libcore 1.49 into libgrust/libcore. LICENSE-* files are taken from the rustc 1.49 repository root. Signed-off-by: Owen Avery <[email protected]>
powerboat9
force-pushed
the
vendor-core
branch
from
94d3b93 to
ba9d65a
Compare
CohenArthur
approved these changes
Aug 11, 2025
|
Yep. |
P-E-P
approved these changes
Aug 13, 2025
There was a problem hiding this comment.
Mmh a bit sad that the Cargo.toml in libcore does not document the library's version. I like @philberty 's idea to track the source of the library, not sure the hash is required but the version should be. And it should be somewhere close so we won't forget to update it. Otherwise LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This vendors
libcoreunderlibgrust. In the future we can use this for buildinglibcoreas a runtime library, and in the near-future we can use it to test progressively later phases of the compiler onlibcoreas part of the testsuite.