Skip to content

Conversation

@Brayan-724
Copy link
Member

@Brayan-724 Brayan-724 commented Jun 23, 2025

For expand the support of UI frameworks/libraries and don't copy-paste styles of each component, I create a centralized tailwindcss definitions that will be shared between all technologies.

  • Create the centralized styles
  • Migrate current ReactJS components

@Brayan-724
Copy link
Member Author

@Josem1801 See this just to know how this project will evolve.

@Brayan-724 Brayan-724 added enhancement New feature or request React Related to React.js New Support Add or request support for new framework or library labels Jun 23, 2025
@Brayan-724 Brayan-724 self-assigned this Jun 23, 2025
@Brayan-724
Copy link
Member Author

I need feedback to select the class prefix for components:

  • component (no-prefix, may create conflicts)
    <div class="component" />
  • rs-component
    <div class="rs-component" />
  • rses-component
    <div class="rses-component" />
  • rles-component
    <div class="rles-component" />
  • rustlanges-component
    <div class="rustlanges-component" />

@SergioRibera @Josem1801 @gg0074x @Phosphorus-M

@SergioRibera
Copy link
Member

I need feedback to select the class prefix for components

@Brayan-724 I personally like rustlanges-component better, mostly because our name does not have a short variant that we can take advantage of.

@Phosphorus-M
Copy link
Member

Maybe it's a little obvious but could we use a name? I mean, this is a library right? 😃 Jajxjad
Give a name to your library ✨
It's better for everyone, because then you can just search the name of the library in npm and it's all.

@Brayan-724
Copy link
Member Author

@Phosphorus-M

I mean, this is a library right? 😃 Jajxjad

Yes, but is an internal one. The library doesn't pretend to be downloaded by external developers, just for those who want our specific design.

Give a name to your library ✨

If you have a name to suggest, I'm open to listen you, but is not a key-point to be searchable because the README.md shows how to install it.

@Josem1801
Copy link
Contributor

@Brayan-724 Personally, I prefer the first one:

component (no prefix, but may cause conflicts)

However, if it might create conflicts in the future,
rustlanges-component seems like the better option.

@Phosphorus-M
Copy link
Member

Phosphorus-M commented Jun 24, 2025

@Brayan-724 owo

Yes, but is an internal one. The library doesn't pretend to be downloaded by external developers, just for those who want our specific design.

Oh! Okay I understand what do you mean, but anyone could just download the library and use it, I mean it's not exactly internal if you have the code public, and you don't use a private registry, anyone could download the library and use it, but yeah

Understanding that it's Tailwind I prefer something like:

<div class="rles-component" />

Why? Because if you choose the last one you need to write a lot just to start to define the style and usually for tailwind you use at least 5 classes, so could extend a lot the length of a line. Not for any other reason, to be honest, it's the same.

Give a name to your library ✨

I change my opinion now ✨
It was like a marketing idea because usually it's weird search the styles with the name of the organization, usually you use a name for identifying the library and create personal brand, use the same name of your organization is a little weird in my opinion but yeah I don't know, it's just an opinion not rocket science ¯_(ツ)_/¯

@Brayan-724 Brayan-724 force-pushed the tailwindcss-centralized branch from 364af00 to aecaa7c Compare June 24, 2025 19:37
@Brayan-724 Brayan-724 marked this pull request as ready for review June 24, 2025 21:08
@SergioRibera SergioRibera added this to the First Launch 🎉 milestone Jun 25, 2025
@Brayan-724 Brayan-724 merged commit 807c010 into main Jun 25, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from In review to Done in Design System Components Jun 25, 2025
@Brayan-724 Brayan-724 deleted the tailwindcss-centralized branch June 25, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request New Support Add or request support for new framework or library React Related to React.js

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants