Skip to content

Conversation

@bryanlundberg
Copy link

@bryanlundberg bryanlundberg commented Nov 2, 2025

Description

This pull request involves significant improvements to the codebase in terms of responsiveness, styling, and readability:

  • Introduced dynamic sizing hooks for better responsiveness and revamped ReactPanelContainer functionality.
  • Updated ReactPanelContainer styles and improved the resize handle structure for better user experience.
  • Replaced Astro components with React-based alternatives, improving content handling and maintainability.
  • Migrated shared Section.astro usage to native HTML <section> for more standardized and clear markup.
  • Cleaned up unused linter overrides, including removal of noDangerouslySetInnerHtml rule, and resolved a unique key issue in the Sidebar component.
image

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

⚡ Cloudflare Pages Deployment

Name Status Preview
preview-experimental-drag-react ✅ Ready (Logs) 26d68c76

@bryanlundberg bryanlundberg marked this pull request as draft November 2, 2025 03:39
@github-actions
Copy link

github-actions bot commented Nov 2, 2025

⚡ Cloudflare Pages Deployment

Name Status Preview
preview-experimental-drag-react ✅ Ready (Logs) b0c9f7c5

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

⚡ Cloudflare Pages Deployment

Name Status Preview
preview-experimental-drag-react ✅ Ready (Logs) 5ee6955c

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

⚡ Cloudflare Pages Deployment

Name Status Preview
preview-experimental-drag-react ✅ Ready (Logs) adab6088

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

⚡ Cloudflare Pages Deployment

Name Status Preview
preview-experimental-drag-react ✅ Ready (Logs) 2ab95f16

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

⚡ Cloudflare Pages Deployment

Name Status Preview
preview-experimental-drag-react ✅ Ready (Logs) 4d009c74

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

⚡ Cloudflare Pages Deployment

Name Status Preview
preview-experimental-drag-react ✅ Ready (Logs) e1af0d0d

@bryanlundberg bryanlundberg marked this pull request as ready for review November 2, 2025 16:36
@github-actions
Copy link

github-actions bot commented Nov 2, 2025

⚡ Cloudflare Pages Deployment

Name Status Preview
preview-experimental-drag-react ✅ Ready (Logs) 27fd1412

- Remove content.config.ts and replace with more direct content management
- Update ReactMarkdownContainer to remove unnecessary elements and simplify layout
- Refactor NavButtons.astro to use new meta props
- Remove dynamic content loading from Hero component
- Adjust Navbar and other components to support new content management approach
- Add new content-manager.ts helper to potentially replace previous configuration method
@bryanlundberg bryanlundberg reopened this Nov 3, 2025
@SergioRibera
Copy link
Member

Justo for help, I have that with this preview

Screenshot_2025-11-02-20-37-18-268_org.mozilla.firefox.jpg

And the current astro migration branch looks like this

Screenshot_2025-11-02-20-40-26-468_org.mozilla.firefox.jpg

Maybe this will be useful for designing the responsive version

@ArturoAtomplay
Copy link
Contributor

@SergioRibera We'll keep that in mind. Perhaps a simple solution would be to switch to tabs when it reaches a certain size

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

⚡ Cloudflare Pages Deployment

Name Status Preview
preview-experimental-drag-react ✅ Ready (Logs) 926b02e3

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

⚡ Cloudflare Pages Deployment

Name Status Preview
preview-experimental-drag-react ✅ Ready (Logs) f0c933c5

@bryanlundberg
Copy link
Author

bryanlundberg commented Nov 3, 2025

Justo for help, I have that with this preview

Maybe this will be useful for designing the responsive version

La intención es utilizar esta distribución, aunque faltaría que detecte el useAgent para tomar forma al entrar.

iPhone-13-PRO-MAX-localhost image

@SergioRibera
Copy link
Member

@ArturoAtomplay They could consider the previous alternative for when the screen is very small, as it can occupy a considerable percentage of space

@SergioRibera
Copy link
Member

Estuve revisando el código y veo que cambiaron bastante, en lo que estoy viendo la propuesta quita la parte estática que era lo que nos interesa realmente, cargar la menor cantidad de js posible, entre otras cosas que no me agradan mucho de la contribucion por la parte de react es la micro componetización que se implementó y como muchas cosas que podrian ser css pasaron a ser js, por lo que se discutió con el equipo y decidimos continuar con la implementación de Astro actual

@RustLangES RustLangES locked as too heated and limited conversation to collaborators Nov 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants