Skip to content

Conversation

@tobiasso85
Copy link
Contributor

hasOwnPreload is only true if the library has embeds field set in manifest
and embedded manifest does not have a backlink (embeddedBy) to the library.

hasOwnPreload is only true if the library has embeds field set in manifest
and embedded manifest does not have a backlink (embeddedBy) to the library.
@tobiasso85 tobiasso85 requested review from codeworrior and matz3 March 4, 2021 14:43
@coveralls
Copy link

coveralls commented Mar 4, 2021

Coverage Status

Coverage increased (+0.0009%) to 93.97% when pulling 8368d77 on versionInfoGenerator-hasOwnPreload-fix into fe61d6e on master.

@matz3
Copy link
Member

matz3 commented Mar 4, 2021

I find hasOwnPreload switched boolean a bit hard to understand as a bug fix message.

Basically this is now fixing how the behavior of the hasOwnPreload flag was intended to be (as follow-up of #554).

@tobiasso85 tobiasso85 changed the title [FIX] versionInfoGenerator: hasOwnPreload switched boolean [FIX] versionInfoGenerator: fix hasOwnPreload flag Mar 4, 2021
@tobiasso85 tobiasso85 merged commit 73a0f8b into master Mar 4, 2021
@tobiasso85 tobiasso85 deleted the versionInfoGenerator-hasOwnPreload-fix branch March 4, 2021 16:40
d3xter666 pushed a commit to UI5/cli that referenced this pull request Sep 25, 2025
…builder#591)

hasOwnPreload is only true if the library has embeds field set in manifest
and embedded manifest does not have a backlink (embeddedBy) to the library.

restructure component object such that hasOwnPreload comes as first property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants