Skip to content

Implement support for new Edge based on Chromium (rename the current Edge to EdgeLagacy) #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Implement support for new Edge based on Chromium (rename the current Edge to EdgeLagacy) #166

wants to merge 30 commits into from

Conversation

@danieljtag
Copy link
Contributor

@danieljtag danieljtag commented Feb 11, 2020

Implement support for new Edge browser based on Chromium (rename the current Edge to EdgeLagacy)
Implement get Edge (Chromium) WebDriver automatically from url

Created this new pull-request that will replace pull-requests #163 & #164
(see also comments on pull-request #163)

simplesoftlabs
simplesoftlabs reviewed Feb 12, 2020
View reviewed changes
This was referenced Feb 14, 2020
Closed
Closed
@danieljtag
Copy link
Contributor Author

danieljtag commented Feb 17, 2020 •
edited
Loading

After verification, looks like there is no 'redirect url' (as for firefox case) or LATEST_RELEASE_X url (as for chrome case) to get the latest webdriver version from Microsoft for Edge chromium.

How do you suggest to identify the latest WebDriver version from Microsoft web site? For now in this pull request, Edge webdriver download and file re-name is working ok, but the version (major + minor) must be in profile.conf.js

@danieljtag
Copy link
Contributor Author

danieljtag commented Mar 6, 2020

Let me know if any other comments, thank you

@danieljtag
Copy link
Contributor Author

danieljtag commented Mar 6, 2020

Fyi, for any testing from this fork (before a merge to master) the profile.conf.js file must be maintained with:
latestCompleteVersionFileUrl: 'https://raw.githubusercontent.com/danieljtag/ui5-uiveri5/master/driverVersions.json'

@CLAassistant
Copy link

CLAassistant commented Mar 16, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

tsaleksandrova
tsaleksandrova reviewed Mar 16, 2020
View reviewed changes
@danieljtag
Copy link
Contributor Author

danieljtag commented May 7, 2020

any update about the merge ?

@danieljtag
Copy link
Contributor Author

danieljtag commented Aug 14, 2020

@maximnaidenov could you review this pull request ? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@simplesoftlabs simplesoftlabs simplesoftlabs left review comments

@tsaleksandrova tsaleksandrova tsaleksandrova left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@danieljtag @CLAassistant @simplesoftlabs @tsaleksandrova @danjtag789