Skip to content

fix(ui5-token): align delete icon tooltip with latest spec #11887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −2
Open

fix(ui5-token): align delete icon tooltip with latest spec #11887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b539e0
fix(ui5-token): align delete icon tooltip with latest spec
MapTo0 Jul 9, 2025
d7bc3c0
Merge branch 'main' into token-delete-tooltip
MapTo0 Jul 17, 2025
6c32d87
Merge branch 'main' into token-delete-tooltip
MapTo0 Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/main/src/Token.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
} from "@ui5/webcomponents-base/dist/Keys.js";
import type I18nBundle from "@ui5/webcomponents-base/dist/i18nBundle.js";
import i18n from "@ui5/webcomponents-base/dist/decorators/i18n.js";
import { TOKEN_ARIA_DELETABLE, TOKEN_ARIA_LABEL } from "./generated/i18n/i18n-defaults.js";
import { TOKEN_ARIA_DELETABLE, TOKEN_ARIA_LABEL, TOKEN_ARIA_REMOVE } from "./generated/i18n/i18n-defaults.js";

import type { IIcon } from "./Icon.js";
import type { IToken } from "./MultiInput.js";
Expand Down Expand Up @@ -200,7 +200,7 @@ class Token extends UI5Element implements IToken {
}

get tokenDeletableText() {
return Token.i18nBundle.getText(TOKEN_ARIA_DELETABLE);
return Token.i18nBundle.getText(TOKEN_ARIA_REMOVE);
}

get textDom() {
Expand Down
3 changes: 3 additions & 0 deletions packages/main/src/i18n/messagebundle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,9 @@ DATETIME_PICKER_TIME_BUTTON=Time
#XACT: ARIA announcement for token deletable
TOKEN_ARIA_DELETABLE=Deletable

#XACT: ARIA announcement for token removal
TOKEN_ARIA_REMOVE=Remove

#XACT: ARIA announcement for token label
TOKEN_ARIA_LABEL=Token

Expand Down
Loading